-
Notifications
You must be signed in to change notification settings - Fork 4
Support DuckDB Dialect #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hadia206
wants to merge
13
commits into
main
Choose a base branch
from
Hadia/duckdb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0f1950d
[run CI][run dialects] duckdb setup and tpch testing
hadia206 5032272
[run CI][run duckdb] use sqlite db to match data
hadia206 428739c
defog
hadia206 635a3c7
[run CI][run dialects] update files and download tpch for duckdb
hadia206 bbbd560
[run CI][run dialects][run s3]
hadia206 fdc395e
[run CI][run s3][run dialects] use fetchdf and cleanup
hadia206 1101f73
[run CI][run dialects][run s3] cleanup
hadia206 6b9fb7e
[run CI][run dialects] docs
hadia206 90f3c21
[run CI][run s3][run dialects] update databricks defog sql to use cor…
hadia206 fba29d6
[run CI][run dialects] comments
hadia206 6816232
Merge branch 'main' of https://github.com/bodo-ai/PyDough into Hadia/…
hadia206 e8f55f4
Merge branch 'main' of https://github.com/bodo-ai/PyDough into Hadia/…
hadia206 5306bca
[run CI][run dialects][run s3] address John's comment
hadia206 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| name: Run DuckDB Tests | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| python-versions: | ||
| description: "JSON string of Python versions" | ||
| type: string | ||
| required: true | ||
|
|
||
| jobs: | ||
| duckdb-tests: | ||
| name: DuckDB Tests (Python ${{ matrix.python-version }}) | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ${{ fromJSON(inputs.python-versions) }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Python ${{ matrix.python-version }} | ||
| id: setup-python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v3 | ||
| with: | ||
| version: "0.6.0" | ||
|
|
||
| - name: Create virtual environment | ||
| # See sf_testing.yml on why we use `uv venv` | ||
| run: uv venv | ||
|
|
||
| - name: Install dependencies | ||
| run: uv pip install -e ".[duckdb]" | ||
|
|
||
| - name: Confirm DuckDB connector is installed | ||
| run: uv run python -c "import duckdb; print('DuckDB connector installed')" | ||
|
|
||
| - name: Download TPCH DB | ||
| run: ./demos/setup_tpch.sh ./tpch.db | ||
|
|
||
| - name: Run DuckDB Tests | ||
| run: uv run pytest -m duckdb tests/ -rs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,4 +30,4 @@ Once the introduction notebook is complete, you can explore the other notebooks: | |
| - [Oracle_TPCH.ipynb](notebooks/Oracle_TPCH.ipynb) demonstrates how to connect an Oracle database with PyDough. | ||
| - [Databricks_TPCH.ipynb](notebooks/Databricks_TPCH.ipynb) demonstrates how to connect a Databricks database with PyDough. | ||
| - [Trino_TPCH.ipynb](notebooks/Trino_TPCH.ipynb) demonstrates how to connect a Trino database with PyDough. | ||
|
|
||
| - [DuckDB_TPCH.ipynb](notebooks/DuckDB_TPCH.ipynb) demonstrates how to connect a DuckDB database with PyDough. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We didn't add |
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Force regenerating with each run. This was mainly because I had to stop running the testing mid running and that made the data incomplete.