feat(postfix-exporter): releasing tagged postfix exporter images#268
Conversation
|
Todo:
|
dd082f8 to
e1f5ee2
Compare
|
@bokysan I tried testing this by pushing a tag to my fork, but the job fails because I haven't set up variables / secrets, pages, registry, ... in my fork. Are the changes small enough for you to verify without? |
|
I'll check it out and merge when I'm at the keyboard. Regarding version tags - there was one ticket that somebody had issues (I don't remember now if he neededn |
|
Great, thanks! I found #216 reporting an issue resulting from this, where Looking at your comment from back then in that issue, the reasoning seems to have been related to the fact that Helm expects Judging from other charts I use, from projects that release v-prefixed tags, releasing the Chart as If I'm not mistaken, releasing Charts to OCI registries instead of Helm HTTP Repositories (which would be a nice addition at some point) would not only expect a non-prefixed version, but actually blocks prefixed versions from being pushed - but could have been another tool in our pipeline complaining about this as well, not sure anymore. I'll see if this still feels icky later in the day and if I didn't forget about it already, and open an issue for further discussions :) |
bokysan
left a comment
There was a problem hiding this comment.
Can you check the one comment above, please?
Moves buildx-setup, which already uses get-release-version, from build-postfix-exporter action to Build_PostfixExporter job. That way, release version env vars can be used in job, without needlessly running get-release-version from within the action again.
e39aa60 to
69a6203
Compare
As we are now aligning the build version of `postfix-exporter` with the build version of the image. Hance it doesn't make sense to build `:latest` from the main branch anymore, but to build it from the latest tag (as it is the case with the main docker image).
Added release version tags to postfix-exporter image builds in tag workflows.
Moving
buildx-setupaction frombuild-postfix-exporteraction toBuild_PostfixExporterjob, so version env vars are available for defining image tags.Also added
buildx-setupaction to the job in master branch as well, so build environment is still properly set up (since the action itself doesn't do it anymore).Updated
mailHelm Chart to use metrics image version through Chart AppVersion.Fixes #264