Skip to content

feat(postfix-exporter): releasing tagged postfix exporter images#268

Merged
bokysan merged 4 commits into
bokysan:masterfrom
outofrange:feat/264-tagged-postfix-exporter-images
Mar 9, 2026
Merged

feat(postfix-exporter): releasing tagged postfix exporter images#268
bokysan merged 4 commits into
bokysan:masterfrom
outofrange:feat/264-tagged-postfix-exporter-images

Conversation

@outofrange
Copy link
Copy Markdown
Contributor

@outofrange outofrange commented Mar 6, 2026

Added release version tags to postfix-exporter image builds in tag workflows.

Moving buildx-setup action from build-postfix-exporter action to Build_PostfixExporter job, so version env vars are available for defining image tags.
Also added buildx-setup action to the job in master branch as well, so build environment is still properly set up (since the action itself doesn't do it anymore).

Updated mail Helm Chart to use metrics image version through Chart AppVersion.

Fixes #264

@outofrange
Copy link
Copy Markdown
Contributor Author

outofrange commented Mar 6, 2026

Todo:

  • Setting postfix-exporter version tag in Helm chart releases

@outofrange outofrange force-pushed the feat/264-tagged-postfix-exporter-images branch from dd082f8 to e1f5ee2 Compare March 6, 2026 04:26
@outofrange outofrange marked this pull request as ready for review March 6, 2026 04:34
Comment thread .github/workflows/tags.yml
@outofrange
Copy link
Copy Markdown
Contributor Author

@bokysan I tried testing this by pushing a tag to my fork, but the job fails because I haven't set up variables / secrets, pages, registry, ... in my fork.

Are the changes small enough for you to verify without?

@bokysan
Copy link
Copy Markdown
Owner

bokysan commented Mar 6, 2026

I'll check it out and merge when I'm at the keyboard.

Regarding version tags - there was one ticket that somebody had issues (I don't remember now if he needednv or without) so we're tagging for both. Since both images are the same, I didn't see any harm in it.

@outofrange
Copy link
Copy Markdown
Contributor Author

Great, thanks!

I found #216 reporting an issue resulting from this, where helm search repo can get confusing as well.

Looking at your comment from back then in that issue, the reasoning seems to have been related to the fact that Helm expects X.Y.Z SemVer format, without the v prefix.
But I'm not sure if you didn't refer to a different issue, since #216 alone doesn't explain why the Helm chart with vX.Y.Z is then still being released.

Judging from other charts I use, from projects that release v-prefixed tags, releasing the Chart as X.Y.Z, with an AppVersion like vX.Y.Z is a common approach.

If I'm not mistaken, releasing Charts to OCI registries instead of Helm HTTP Repositories (which would be a nice addition at some point) would not only expect a non-prefixed version, but actually blocks prefixed versions from being pushed - but could have been another tool in our pipeline complaining about this as well, not sure anymore.

I'll see if this still feels icky later in the day and if I didn't forget about it already, and open an issue for further discussions :)

Copy link
Copy Markdown
Owner

@bokysan bokysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the one comment above, please?

Comment thread .github/workflows/tags.yml Outdated
Comment thread .github/workflows/tags.yml
Moves buildx-setup, which already uses get-release-version,
from build-postfix-exporter action to Build_PostfixExporter job.

That way, release version env vars can be used in job, without needlessly
running get-release-version from within the action again.
@outofrange outofrange force-pushed the feat/264-tagged-postfix-exporter-images branch from e39aa60 to 69a6203 Compare March 6, 2026 22:40
Comment thread .github/workflows/tags.yml
@bokysan bokysan merged commit aadfbfa into bokysan:master Mar 9, 2026
5 checks passed
bokysan added a commit that referenced this pull request Mar 9, 2026
As we are now aligning the build version of `postfix-exporter` with the
build version of the image.

Hance it doesn't make sense to build `:latest` from the main branch
anymore, but to build it from the latest tag (as it is the case with the
main docker image).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of proper image tags for the postfix-exporter

2 participants