Skip to content

Commit 93ff030

Browse files
committed
fix(ie-shell): fix segfault on window close — drop gpu_renderer before window #77
Rust drops struct fields in declaration order. The GpuRenderer holds a wgpu::Surface that references the Window, so it must be dropped first. Reorder fields: gpu_renderer before window.
1 parent 5e65c31 commit 93ff030

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

crates/ie-shell/src/app.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,10 @@ pub enum UserEvent {
1919
}
2020

2121
pub struct Browser {
22-
window: Option<Arc<Window>>,
22+
// gpu_renderer MUST be before window — it holds a wgpu::Surface
23+
// referencing the window, so it must drop first
2324
gpu_renderer: Option<ie_render::GpuRenderer>,
25+
window: Option<Arc<Window>>,
2426
tab_manager: TabManager,
2527
bookmark_store: BookmarkStore,
2628
overlay: OverlayState,

0 commit comments

Comments
 (0)