Skip to content

fix(@clack/prompts): handle carriage return output in taskLog#509

Closed
colinaaa wants to merge 2 commits into
bombshell-dev:mainfrom
colinaaa:fix/task-log-carriage-return
Closed

fix(@clack/prompts): handle carriage return output in taskLog#509
colinaaa wants to merge 2 commits into
bombshell-dev:mainfrom
colinaaa:fix/task-log-carriage-return

Conversation

@colinaaa

@colinaaa colinaaa commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • handle taskLog raw message updates that use carriage returns so spinner frames do not accumulate
  • add regression coverage for carriage-return spinner output and error() rendering behavior
  • add a changeset for the @clack/prompts patch release

Test Plan

  • cd packages/prompts && pnpm test

@changeset-bot

changeset-bot Bot commented Apr 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 64f726a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Apr 8, 2026

Copy link
Copy Markdown

commit: 64f726a

@43081j

43081j commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

while this may be a nice fix to have, its not the way we should fix this.

the spinner has similar issues in that it is a "raw" prompt (doesn't inherit Prompt and implements its own rendering logic).

going forward, the spinner is going to be refactored to use the same rendering logic as every other prompt. The task log prompt should do the same, and that will solve this problem at the same time.

an issue goes a long way here as not all this direction is written down in one place, so you couldn't really have known that refactor was in progress.

@colinaaa

colinaaa commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

@43081j thanks for your review! I'll create an issue instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants