fix: prevent duplicate empty args in generated completions #442
AmirSa12ci.yml
on: pull_request
Lint and Type Check
20s
Benchmarks
19s
Matrix: Tests
Annotations
6 errors and 6 warnings
|
Tests (macos-latest)
Process completed with exit code 1.
|
|
tests/shell-empty-argv.test.ts > generated shell argv protocol > PowerShell sends exactly one empty arg for root empty completion:
tests/shell-empty-argv.test.ts#L344
AssertionError: stdout:
stderr:
No application knows how to open URL file:///var/folders/bh/cdl3cft92_dbvg852_fp7y7w0000gn/T/tab-shell-empty-argv-KTRf16/powershell.completion (Error Domain=NSOSStatusErrorDomain Code=-10814 "kLSApplicationNotFoundErr: E.g. no application claims the file" UserInfo={_LSLine=1796, _LSFunction=runEvaluator}).
InvalidOperation:
Line |
15 | & $__demoCompleterBlock '' $commandAst 5 | Out-Null
| ~~~~~~~~~~~~~~~~~~~~~
| The expression after '&' in a pipeline element produced an object that was not valid. It must result in a command name, a script block, or a CommandInfo object.
: expected 1 to be +0 // Object.is equality
- Expected
+ Received
- 0
+ 1
❯ assertPowerShellCase tests/shell-empty-argv.test.ts:344:5
❯ tests/shell-empty-argv.test.ts:412:9
❯ withFixture tests/shell-empty-argv.test.ts:189:5
❯ tests/shell-empty-argv.test.ts:410:5
|
|
Tests (windows-latest)
The strategy configuration was canceled because "test.macos-latest" failed
|
|
Tests (windows-latest)
The operation was canceled.
|
|
Tests (ubuntu-latest)
The strategy configuration was canceled because "test.macos-latest" failed
|
|
Tests (ubuntu-latest)
The operation was canceled.
|
|
Lint and Type Check
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4.0.0. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Lint and Type Check:
src/commander.ts#L2
Imports "TabCommand" and "OptionHandler" are only used as type
|
|
Benchmarks
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4.0.0. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Tests (macos-latest)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4.0.0. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Tests (windows-latest)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4.0.0. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Tests (ubuntu-latest)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4.0.0. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|