Conversation
|
commit: |
AmirSa12
changed the title
| export function setupPnpmCompletions(completion: Completion) { | ||
| completion.addCommand('add', 'Install a package', [], async () => []); | ||
| completion.addCommand('remove', 'Remove a package', [], async () => []); | ||
| completion.addCommand('add', 'Install a package', [], noopCompletion); |
There was a problem hiding this comment.
i thought descriptions were being retrieved from the package managers themselves as we talked. we should not do that manually.
| // TODO: i do not see any completion functionality in this file. nothing is being provided for the defined commands of these package managers. this is a blocker for release. every each of them should be handled. | ||
| import { Completion } from '../src/index.js'; | ||
|
|
||
| const noopCompletion = async () => []; |
There was a problem hiding this comment.
this is not an efficiency and performance win, it's more like a syntactic optimization.
There was a problem hiding this comment.
@Aslemammad, I mean, if we think technically (though it’s a very small difference), the inlined way creates more memory allocations, and more allocations technically mean slightly less efficient memory usage.
but yeah we won’t see a real performance or memory impact either way in this case!
2 participants
No description provided.