Skip to content

fix: cac: treat options correctly#60

Merged
AmirSa12 merged 3 commits intomainfrom
fix/treat-options
Sep 26, 2025
Merged

fix: cac: treat options correctly#60
AmirSa12 merged 3 commits intomainfrom
fix/treat-options

Conversation

@AmirSa12
Copy link
Copy Markdown
Member

@AmirSa12 AmirSa12 commented Sep 25, 2025

cac was treating all options without custom handlers as boolean flags, even if they were defined to take values like --port
but now cac sets this to true for parameters and the regex loooks for <value> or [optional] in the rawName

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 25, 2025

⚠️ No Changeset found

Latest commit: 59b852c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Sep 25, 2025

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/tab/@bomb.sh/tab@60

commit: 59b852c

@AmirSa12 AmirSa12 merged commit 1080e7c into main Sep 26, 2025
9 checks passed
@AmirSa12 AmirSa12 deleted the fix/treat-options branch September 26, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant