Skip to content

fix: use npx for portable completion scripts #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aslemammad merged 2 commits into from
Oct 18, 2025
+8 −10
Merged

fix: use npx for portable completion scripts #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
111887b
fix: use npx for portable completion scripts
AmirSa12 Oct 18, 2025
98d8dbb
use npm user agent
AmirSa12 Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/crazy-beds-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@bomb.sh/tab': patch
---

fix: use npx for portable completion scripts instead of absolute paths
13 changes: 3 additions & 10 deletions bin/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,11 @@ async function main() {
cli.parse();
}

// function generateCompletionScript(packageManager: string, shell: string) {
// const name = packageManager;
// const executable = process.env.npm_execpath
// ? `${packageManager} exec @bomb.sh/tab ${packageManager}`
// : `node ${process.argv[1]} ${packageManager}`;
// script(shell as any, name, executable);
// }

function generateCompletionScript(packageManager: string, shell: string) {
const name = packageManager;
// this always points at the actual file on disk (TESTING)
const executable = `node ${process.argv[1]} ${packageManager}`;
const executable = process.env.npm_config_user_agent
? `npx --yes @bomb.sh/tab ${packageManager}`
: `node ${process.argv[1]} ${packageManager}`;
script(shell as any, name, executable);
}

Expand Down
Loading