ref(bench): centralize withCodSpeed workaround

Author: natemoo-re

bench/fixtures/utils.ts

@@ -1,6 +1,17 @@
 import { fileURLToPath } from "node:url";
 import { spawn } from "node:child_process";
 
+export { withCodSpeed } from "@codspeed/tinybench-plugin";
+
+// CodSpeed walltime reads `task.result.latency` which
+// tinybench only sets for async tasks
+export function sync(fn: () => void): () => Promise<void> {
+  return () => {
+    fn();
+    return Promise.resolve();
+  };
+}
+
 export const fixture = (name: string) => {
   return new URL(`./${name}/mod.ts`, import.meta.url);
 };

bench/ops.bench.ts

@@ -1,5 +1,5 @@
 import { Bench } from "tinybench";
-import { withCodSpeed } from "@codspeed/tinybench-plugin";
+import { sync, withCodSpeed } from "./fixtures/utils.ts";
 import { close, fixed, grow, open, pack, rgba, text } from "../ops.ts";
 import type { Op } from "../ops.ts";
 
@@ -97,14 +97,18 @@ let buf = new ArrayBuffer(32768);
 let bench = withCodSpeed(new Bench({ name: "ops" }));
 
 bench
-  .add("pack complex layout", () => {
-    for (let i = 0; i < 1500; i++) pack(complexOps, buf, 0);
-    return Promise.resolve();
-  })
-  .add("pack large list", () => {
-    for (let i = 0; i < 250; i++) pack(listOps, buf, 0);
-    return Promise.resolve();
-  });
+  .add(
+    "pack complex layout",
+    sync(() => {
+      for (let i = 0; i < 1500; i++) pack(complexOps, buf, 0);
+    }),
+  )
+  .add(
+    "pack large list",
+    sync(() => {
+      for (let i = 0; i < 250; i++) pack(listOps, buf, 0);
+    }),
+  );
 
 await bench.run();
 console.table(bench.table());

bench/render.bench.ts

@@ -1,5 +1,5 @@
 import { Bench } from "tinybench";
-import { withCodSpeed } from "@codspeed/tinybench-plugin";
+import { sync, withCodSpeed } from "./fixtures/utils.ts";
 import { createTerm } from "../term.ts";
 import { close, fixed, grow, open, rgba, text } from "../ops.ts";
 import type { Op } from "../ops.ts";
@@ -103,18 +103,22 @@ let uiOps: Op[] = [
 let bench = withCodSpeed(new Bench({ name: "render" }));
 
 bench
-  .add("render mixed frames", () => {
-    for (let i = 0; i < 250; i++) {
-      term.render(i % 2 === 0 ? dashboardOps : uiOps);
-    }
-    return Promise.resolve();
-  })
-  .add("render steady diff", () => {
-    for (let i = 0; i < 250; i++) {
-      term.render(dashboardOps);
-    }
-    return Promise.resolve();
-  });
+  .add(
+    "render mixed frames",
+    sync(() => {
+      for (let i = 0; i < 250; i++) {
+        term.render(i % 2 === 0 ? dashboardOps : uiOps);
+      }
+    }),
+  )
+  .add(
+    "render steady diff",
+    sync(() => {
+      for (let i = 0; i < 250; i++) {
+        term.render(dashboardOps);
+      }
+    }),
+  );
 
 await bench.run();
 console.table(bench.table());

bench/startup.bench.ts

@@ -1,6 +1,5 @@
 import { Bench } from "tinybench";
-import { withCodSpeed } from "@codspeed/tinybench-plugin";
-import { spawnFixture } from "./fixtures/utils.ts";
+import { spawnFixture, withCodSpeed } from "./fixtures/utils.ts";
 
 let bench = withCodSpeed(new Bench({ name: "startup" }));
 

bench/throughput.bench.ts

@@ -1,5 +1,5 @@
 import { Bench } from "tinybench";
-import { withCodSpeed } from "@codspeed/tinybench-plugin";
+import { sync, withCodSpeed } from "./fixtures/utils.ts";
 import { createInput } from "../input.ts";
 
 function str(s: string): Uint8Array {
@@ -33,15 +33,17 @@ let input = await createInput({ escLatency: 25 });
 
 let bench = withCodSpeed(new Bench({ name: "throughput" }));
 
-bench.add("input throughput (mixed corpus, chunked read loop)", () => {
-  let dispatched = 0;
-  for (let off = 0; off < corpus.length; off += READ) {
-    let { events } = input.scan(corpus.subarray(off, off + READ));
-    dispatched += events.length;
-  }
-  if (dispatched === 0) throw new Error("expected events");
-  return Promise.resolve();
-});
+bench.add(
+  "input throughput (mixed corpus, chunked read loop)",
+  sync(() => {
+    let dispatched = 0;
+    for (let off = 0; off < corpus.length; off += READ) {
+      let { events } = input.scan(corpus.subarray(off, off + READ));
+      dispatched += events.length;
+    }
+    if (dispatched === 0) throw new Error("expected events");
+  }),
+);
 
 await bench.run();
 console.table(bench.table());