Add extra workload types#4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the
baseHelm chart, making it more flexible and extensible by supporting multiple Kubernetes workload types beyond just Deployments. The chart can now deploy DaemonSets, StatefulSets, and standalone Pods, with new configuration options for each workload type. The documentation and versioning have also been updated to reflect these improvements.Workload type support:
DaemonSet,StatefulSet, andPodresources in addition toDeployment, controlled by a newworkloadvalue invalues.yaml. Corresponding templates for each workload type have been added (daemonset.yaml,statefulset.yaml,pod.yaml) and are conditionally rendered based on theworkloadvalue. [1] [2] [3] [4] [5] [6] [7]StatefulSet-specific features:
values.yamlfor StatefulSets, includingserviceName,podManagementPolicy,volumeClaimTemplates, andpersistentVolumeClaimRetentionPolicy, enabling advanced stateful workload management. [1] [2]Configurable update strategies:
updateStrategyvalue to support custom update strategies for DaemonSets and StatefulSets, in addition to the existingstrategyfor Deployments. [1] [2] [3]Documentation updates:
README.mdto document the newworkloadparameter and all additional configuration options for supported workload types, ensuring users understand the expanded capabilities.Versioning and metadata:
0.1.1to0.2.0in bothChart.yamland the version badge inREADME.mdto reflect these breaking and additive changes. [1] [2]