Merge pull request #6 from bookboon/feature/storeAccessTokensAtSameTimeAsAccessTokenExpDate

robo220 · web-flow · commit 680f83b30a52 · 2019-01-17T12:06:51.000Z
Ensure access tokens are stored in cache for the correct access token…
diff --git a/src/Bookboon/ApiBundle/Service/ApiFactory.php b/src/Bookboon/ApiBundle/Service/ApiFactory.php
@@ -44,7 +44,9 @@ public static function credentialFactory(Bookboon $bookboon, Cache $cache, Confi
 
         if ($token === false) {
             $token = $bookboon->getClient()->requestAccessToken([], OauthGrants::CLIENT_CREDENTIALS);
-            $cache->save("bookboonapi.{$config->getId()}", $token);
+
+            $ttl = $token->getExpires() - time();
+            $cache->save("bookboonapi.{$config->getId()}", $token, $ttl);
         }
 
         return $token;

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,9 @@ public static function credentialFactory(Bookboon $bookboon, Cache $cache, Confi`
`44`	`44`
`45`	`45`	`if ($token === false) {`
`46`	`46`	`$token = $bookboon->getClient()->requestAccessToken([], OauthGrants::CLIENT_CREDENTIALS);`
`47`		`- $cache->save("bookboonapi.{$config->getId()}", $token);`
	`47`	`+`
	`48`	`+ $ttl = $token->getExpires() - time();`
	`49`	`+ $cache->save("bookboonapi.{$config->getId()}", $token, $ttl);`
`48`	`50`	`}`
`49`	`51`
`50`	`52`	`return $token;`