Remove adding ubuntu-toolchain-r-test PPA by default

Author: Flamefire

.github/workflows/reusable.yml

@@ -340,9 +340,6 @@ jobs:
         run: |
             SOURCE_KEYS=("${{join(matrix.source_keys, '" "')}}")
             SOURCES=("${{join(matrix.sources, '" "')}}")
-            # Add this by default
-            SOURCE_KEYS+=('http://keyserver.ubuntu.com/pks/lookup?op=get&search=0x1E9377A2BA9EF27F')
-            SOURCES+=(ppa:ubuntu-toolchain-r/test)
 
             ci/add-apt-keys.sh "${SOURCE_KEYS[@]}"
             # Initial update before adding sources required to get e.g. keys

ci/azure-pipelines/install.sh

@@ -46,9 +46,6 @@ if [ "$AGENT_OS" != "Darwin" ]; then
     fi
 
     if [ -n "$PACKAGES" ]; then
-        for i in {1..${NET_RETRY_COUNT:-3}}; do
-            sudo -E apt-add-repository -y "ppa:ubuntu-toolchain-r/test" && break || sleep 10
-        done
         if [ -n "${LLVM_REPO}" ]; then
             curl -sSL --retry ${NET_RETRY_COUNT:-5} https://apt.llvm.org/llvm-snapshot.gpg.key | sudo gpg --dearmor -o /etc/apt/trusted.gpg.d/llvm-snapshot.gpg
             for i in {1..${NET_RETRY_COUNT:-3}}; do

ci/drone/linux-cxx-install.sh

@@ -44,11 +44,11 @@ function add_repository_toolchain {
 
 echo ">>>>> APT: REPOSITORIES..."
 
-if [ "$UBUNTU_TOOLCHAIN_DISABLE" != "true" ]; then
+if [ "${ADD_UBUNTU_TOOLCHAIN_PPA:-}" == "true" ]; then
     # add_repository "ppa:ubuntu-toolchain-r/test"
     add_repository_toolchain "ppa:ubuntu-toolchain-r/test"
 else
-    echo "UBUNTU_TOOLCHAIN_DISABLE is 'true'. Not installing ppa:ubuntu-toolchain-r/test"
+    echo "UBUNTU_TOOLCHAIN_ENABLE is not 'true'. Not installing ppa:ubuntu-toolchain-r/test"
 fi
 
 if [ -n "${LLVM_OS}" ]; then