Skip to content

Commit 32bb746

Browse files
committed
refactor: instantiate MailmanClient locally instead of module-level
1 parent 99dcda6 commit 32bb746

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

mailing_list/views.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
from mailing_list.models import UserMailingListSubscription
2525

2626
logger = logging.getLogger(__name__)
27-
_mailman = MailmanClient()
2827

2928
_CONFIRM_SALT = "mailing-list-confirm-a40b24dc-a26d-49ca-81d1-5b2fccb5fd7b"
3029
_CONFIRM_MAX_AGE = 7 * 24 * 60 * 60 # 7 days in seconds
@@ -182,7 +181,7 @@ def post(self, request):
182181
unsubscribed.append(list_id)
183182
continue
184183
try:
185-
_mailman.unsubscribe(email, list_id)
184+
MailmanClient().unsubscribe(email, list_id)
186185
UserMailingListSubscription.objects.filter(
187186
user=request.user, list_id=list_id
188187
).delete()
@@ -372,7 +371,7 @@ def _handle_authenticated(self, request, email, list_id, managed_lists):
372371

373372
def _handle_anonymous(self, request, email, list_id):
374373
try:
375-
if _mailman.is_confirmed(email, list_id):
374+
if MailmanClient().is_confirmed(email, list_id):
376375
if _is_htmx(request):
377376
return self._card(
378377
request,
@@ -456,7 +455,7 @@ def get(self, request, token):
456455

457456
for list_id in list_ids:
458457
try:
459-
_mailman.subscribe(email, list_id)
458+
MailmanClient().subscribe(email, list_id)
460459
if user is not None:
461460
UserMailingListSubscription.objects.filter(
462461
user=user, list_id=list_id

0 commit comments

Comments
 (0)