Skip to content

Commit 524f29d

Browse files
committed
PR feedback, focus state and aria corrections
1 parent ba40c69 commit 524f29d

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

static/css/v3/badge-button.css

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,14 @@
3333
}
3434

3535
.badge-button:hover,
36-
.badge-button:focus-visible {
36+
.badge-button:has(.badge-button__radio:focus-visible) {
3737
border-radius: var(--border-radius-m);
3838
border: 1px solid var(--color-stroke-strong);
3939
background: var(--color-surface-mid);
4040
padding: 1px;
4141
}
42+
43+
44+
.badge-button:has(.badge-button__radio:focus-visible) {
45+
outline: auto;
46+
}

templates/v3/includes/_badge_button.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@
2525
name="{{name}}"
2626
value="{{value}}"
2727
id="{{id|default:uuid}}"
28-
aria-labelledby="{{id|default:uuid}}_label"
29-
aria-checked="{{radio_checked|yesno:"true,false"|default:"false"}}"
30-
aria-pressed="{{radio_checked|yesno:"true,false"|default:"false"}}"
3128
{% if radio_checked %} checked {% endif %}
3229
/>
3330
<label id="{{id|default:uuid}}_label" for="{{id|default:uuid}}"><img src="{{ icon_src }}" alt="{{ icon_alt }}" width="28" height="28"></label>

0 commit comments

Comments
 (0)