|
6 | 6 | from config.celery import app |
7 | 7 | from config.settings import OPENROUTER_API_KEY, OPENROUTER_URL, SUMMARIZATION_MODEL |
8 | 8 | from news.constants import CONTENT_SUMMARIZATION_THRESHOLD |
9 | | -from news.helpers import UnsafeURLError, extract_article, safe_get |
| 9 | +from news.helpers import UnsafeURLError, extract_article, safe_get, extract_content |
10 | 10 | from news.utils import set_video_thumbnail |
11 | 11 |
|
12 | 12 | logger = structlog.get_logger(__name__) |
@@ -138,18 +138,52 @@ def save_entry_summary_value(summary: str | None, pk: int): |
138 | 138 |
|
139 | 139 |
|
140 | 140 | @app.task |
141 | | -def summary_dispatcher(pk: int): |
| 141 | +def save_page_summary_value(summary: str, pk: int): |
| 142 | + from pages.models import PostPage |
| 143 | + |
| 144 | + # generate_summary returns None/"" on malformed or empty model output; saving |
| 145 | + # that would clobber an existing Entry.summary, so treat it as "do not save". |
| 146 | + if not summary: |
| 147 | + logger.warning(f"Skipping summary save for {pk=}: empty/malformed model output") |
| 148 | + return |
| 149 | + |
| 150 | + page = PostPage.objects.get(pk=pk) |
| 151 | + page.summary = summary |
| 152 | + page.save() |
| 153 | + |
| 154 | + |
| 155 | +@app.task |
| 156 | +def summary_dispatcher(pk: int, model_name: str = "Entry"): |
142 | 157 | from news.models import Entry |
| 158 | + from pages.models import PostPage |
| 159 | + |
| 160 | + if model_name == "PostPage": |
| 161 | + model = PostPage |
| 162 | + elif model_name == "Entry": |
| 163 | + model = Entry |
| 164 | + else: |
| 165 | + logger.warning("Invalid Model Name passed to summary dispatcher") |
| 166 | + return |
143 | 167 |
|
144 | | - entry = Entry.objects.get(pk=pk) |
145 | | - logger.info(f"Dispatching {pk=} with {entry.news_type=}") |
146 | | - handler = { |
147 | | - "news": set_summary_for_event_entry, |
148 | | - "blogpost": set_summary_for_event_entry, |
149 | | - "link": set_summary_for_link_entry, |
150 | | - "video": set_summary_for_video_entry, |
151 | | - "poll": set_summary_for_poll_entry, |
152 | | - }[entry.determined_news_type] |
| 168 | + entry = model.objects.get(pk=pk) |
| 169 | + if model == Entry: |
| 170 | + logger.info(f"Dispatching {pk=} with {entry.news_type=}") |
| 171 | + handler = { |
| 172 | + "news": set_summary_for_event_entry, |
| 173 | + "blogpost": set_summary_for_event_entry, |
| 174 | + "link": set_summary_for_link_entry, |
| 175 | + "video": set_summary_for_video_entry, |
| 176 | + "poll": set_summary_for_poll_entry, |
| 177 | + }[entry.determined_news_type.lower()] |
| 178 | + elif model == PostPage: |
| 179 | + logger.info(f"Dispatching {pk=} with {entry.post_content_type=}") |
| 180 | + handler = { |
| 181 | + "news": set_summary_for_event_page, |
| 182 | + "blogpost": set_summary_for_event_page, |
| 183 | + "link": set_summary_for_link_page, |
| 184 | + "video": set_summary_for_video_page, |
| 185 | + "poll": set_summary_for_poll_page, |
| 186 | + }[entry.determined_news_type.lower()] |
153 | 187 | logger.info(f"Dispatching summary task for {pk=} to {handler.__name__=}") |
154 | 188 | handler.delay(pk) |
155 | 189 |
|
@@ -240,3 +274,68 @@ def sync_post_views_from_plausible(): |
240 | 274 |
|
241 | 275 | updated = update_page_views(slug_views) |
242 | 276 | logger.info("sync_post_views.done", updated=updated) |
| 277 | + |
| 278 | + |
| 279 | +# These tasks emulate the functionality of setting the summmary, but for PostPages instead of Entry. |
| 280 | +# Once the Entry model has been depricated and removed, the above functions can be deleted and the selector logic |
| 281 | +# removed from the dispatcher. |
| 282 | + |
| 283 | + |
| 284 | +@app.task |
| 285 | +def set_summary_for_event_page(pk: int): |
| 286 | + from pages.models import PostPage |
| 287 | + |
| 288 | + page = PostPage.objects.get(pk=pk) |
| 289 | + content = page.content[0].value |
| 290 | + logger.info(f"dispatching summarize task for {pk=} with {content[:40]=}...") |
| 291 | + if content and len(content) < CONTENT_SUMMARIZATION_THRESHOLD: |
| 292 | + logger.warning(f"Content too short to summarize for {pk=}, skipping.") |
| 293 | + return |
| 294 | + logger.info(f"handing off {pk=} to summarize_content task") |
| 295 | + summarize_content.apply_async( |
| 296 | + (content, page.title, SUMMARIZATION_MODEL), |
| 297 | + link=save_page_summary_value.s(pk), |
| 298 | + ) |
| 299 | + |
| 300 | + |
| 301 | +@app.task |
| 302 | +def set_summary_for_link_page(pk: int): |
| 303 | + logger.info(f"Setting summary for link page {pk=}") |
| 304 | + from pages.models import PostPage |
| 305 | + |
| 306 | + page = PostPage.objects.get(pk=pk) |
| 307 | + external_url = page.external_url |
| 308 | + try: |
| 309 | + logger.info(f"Fetching content from {external_url=} for entry.{pk=}") |
| 310 | + response = requests.get(external_url, timeout=10) |
| 311 | + response.raise_for_status() |
| 312 | + markup = response.text |
| 313 | + logger.debug(f"Fetched {len(markup)=} for entry.{pk=}...") |
| 314 | + content = extract_content(markup) |
| 315 | + logger.info(f"extracted content from {external_url=}, {markup[:100]=}") |
| 316 | + except requests.RequestException as e: |
| 317 | + logger.error(f"Error fetching content from {external_url=}: {e=}") |
| 318 | + return |
| 319 | + |
| 320 | + logger.info(f"dispatching summarize task for {pk=} with {content[:40]=}...") |
| 321 | + summarize_content.apply_async( |
| 322 | + (content, page.title, SUMMARIZATION_MODEL), link=save_page_summary_value.s(pk) |
| 323 | + ) |
| 324 | + |
| 325 | + |
| 326 | +@app.task |
| 327 | +def set_summary_for_video_page(pk: int): |
| 328 | + logger.info("Summarization not implemented") |
| 329 | + |
| 330 | + |
| 331 | +@app.task |
| 332 | +def set_summary_for_poll_page(pk: int): |
| 333 | + logger.info("Summarization not implemented") |
| 334 | + |
| 335 | + |
| 336 | +@app.task |
| 337 | +def set_thumbnail_for_video_page(pk: int): |
| 338 | + from pages.models import PostPage |
| 339 | + |
| 340 | + video = PostPage.objects.get(pk=pk) |
| 341 | + set_video_thumbnail(video) |
0 commit comments