feat: no-js

Author: herzog0

mailing_list/mixins.py

@@ -50,8 +50,9 @@ class MailingListCardMixin:
     Adds the variables needed by v3/includes/_mailing_list_card.html:
       mailing_list_card_subscribe_url
       mailing_list_card_list_id
-      mailing_list_card_state              ("pending", "active", or None)
-      mailing_list_card_user_email         (authenticated users only)
+      mailing_list_card_state              ("pending", "active", "error", or None)
+      mailing_list_card_error_message      (set on error state, used by no-JS PRG flow)
+      mailing_list_card_user_email         (authenticated users only, or from PRG params)
       mailing_list_card_manage_url         (authenticated users only)
       mailing_list_card_subscription_count (authenticated users only — ACTIVE count only)
     """
@@ -76,4 +77,16 @@ def get_context_data(self, **kwargs):
                 reverse("profile-account")
             )
 
+        # URL-param overrides for the no-JS PRG flow.
+        # Error state always wins (DB record was rolled back on failure).
+        # Anonymous pending has no DB record so the URL param is the only source.
+        ml_state_param = request.GET.get("ml_state")
+        if ml_state_param == "error":
+            context["mailing_list_card_state"] = "error"
+            context["mailing_list_card_error_message"] = request.GET.get("ml_error", "")
+            context["mailing_list_card_user_email"] = request.GET.get("ml_email", "")
+        elif ml_state_param == "pending" and not request.user.is_authenticated:
+            context["mailing_list_card_state"] = "pending"
+            context["mailing_list_card_user_email"] = request.GET.get("ml_email", "")
+
         return context

mailing_list/views.py

@@ -1,11 +1,13 @@
 import datetime
 import logging
+from urllib.parse import urlencode, urlparse
 
 from django.conf import settings
 from django.contrib.auth import get_user_model
 from django.contrib.auth.mixins import LoginRequiredMixin
 from django.core import signing
 from django.core.mail import send_mail
+from django.http import HttpResponseRedirect
 from django.shortcuts import render
 from django.template.loader import render_to_string
 from django.urls import reverse
@@ -27,6 +29,21 @@
 _CONFIRM_MAX_AGE = 7 * 24 * 60 * 60  # 7 days in seconds
 
 
+def _is_htmx(request) -> bool:
+    return request.headers.get("HX-Request") == "true"
+
+
+def _prg_redirect(request, **params) -> HttpResponseRedirect:
+    """Redirect back to the referring page, with optional query params for card state.
+
+    Strips the referer to path-only to prevent open-redirect issues.
+    """
+    referer = request.headers.get("referer", "/")
+    path = urlparse(referer).path or "/"
+    qs = urlencode({k: v for k, v in params.items() if v})
+    return HttpResponseRedirect(f"{path}?{qs}" if qs else path)
+
+
 def _format_duration(seconds: int) -> str:
     now = timezone.now()
     return timesince(now - datetime.timedelta(seconds=seconds), now, depth=1)
@@ -184,20 +201,31 @@ def post(self, request):
         list_id = request.POST.get("list_id", "").strip()
 
         if not email:
-            return self._card(
-                request,
-                state="error",
-                error_message="Email is required.",
-                list_id=list_id or "boost.lists.boost.org",
+            if _is_htmx(request):
+                return self._card(
+                    request,
+                    state="error",
+                    error_message="Email is required.",
+                    list_id=list_id or "boost.lists.boost.org",
+                )
+            return _prg_redirect(
+                request, ml_state="error", ml_error="Email is required."
             )
 
         if list_id not in managed_lists:
-            return self._card(
+            if _is_htmx(request):
+                return self._card(
+                    request,
+                    state="error",
+                    error_message="Invalid mailing list.",
+                    user_email=email,
+                    list_id=list_id or "boost.lists.boost.org",
+                )
+            return _prg_redirect(
                 request,
-                state="error",
-                error_message="Invalid mailing list.",
-                user_email=email,
-                list_id=list_id or "boost.lists.boost.org",
+                ml_state="error",
+                ml_error="Invalid mailing list.",
+                ml_email=email,
             )
 
         if request.user.is_authenticated:
@@ -213,25 +241,29 @@ def _handle_authenticated(self, request, email, list_id, managed_lists):
 
         if existing:
             if existing.status == SubscriptionStatus.PENDING:
-                return self._card(
-                    request,
-                    state="pending",
-                    user_email=existing.email,
-                    list_id=list_id,
-                    manage_url=manage_url,
-                )
+                if _is_htmx(request):
+                    return self._card(
+                        request,
+                        state="pending",
+                        user_email=existing.email,
+                        list_id=list_id,
+                        manage_url=manage_url,
+                    )
+                return _prg_redirect(request)
             subscription_count = UserMailingListSubscription.objects.filter(
                 user=request.user, list_id__in=managed_lists
             ).count()
-            return render(
-                request,
-                "v3/mailing_list/_subscribe_success_card.html",
-                {
-                    "email": existing.email,
-                    "subscription_count": subscription_count,
-                    "manage_url": manage_url,
-                },
-            )
+            if _is_htmx(request):
+                return render(
+                    request,
+                    "v3/mailing_list/_subscribe_success_card.html",
+                    {
+                        "email": existing.email,
+                        "subscription_count": subscription_count,
+                        "manage_url": manage_url,
+                    },
+                )
+            return _prg_redirect(request)
 
         UserMailingListSubscription.objects.create(
             user=request.user,
@@ -246,31 +278,47 @@ def _handle_authenticated(self, request, email, list_id, managed_lists):
             UserMailingListSubscription.objects.filter(
                 user=request.user, list_id=list_id
             ).delete()
+            if _is_htmx(request):
+                return self._card(
+                    request,
+                    state="error",
+                    error_message="Could not send confirmation email. Please try again.",
+                    user_email=email,
+                    list_id=list_id,
+                )
+            return _prg_redirect(
+                request,
+                ml_state="error",
+                ml_error="Could not send confirmation email. Please try again.",
+                ml_email=email,
+            )
+
+        if _is_htmx(request):
             return self._card(
                 request,
-                state="error",
-                error_message="Could not send confirmation email. Please try again.",
+                state="pending",
                 user_email=email,
                 list_id=list_id,
+                manage_url=manage_url,
             )
-
-        return self._card(
-            request,
-            state="pending",
-            user_email=email,
-            list_id=list_id,
-            manage_url=manage_url,
-        )
+        return _prg_redirect(request)
 
     def _handle_anonymous(self, request, email, list_id):
         try:
             if mailman_is_confirmed(email, list_id):
-                return self._card(
+                if _is_htmx(request):
+                    return self._card(
+                        request,
+                        state="error",
+                        error_message=f"{email} is already subscribed to this list.",
+                        user_email=email,
+                        list_id=list_id,
+                    )
+                return _prg_redirect(
                     request,
-                    state="error",
-                    error_message=f"{email} is already subscribed to this list.",
-                    user_email=email,
-                    list_id=list_id,
+                    ml_state="error",
+                    ml_error=f"{email} is already subscribed to this list.",
+                    ml_email=email,
                 )
         except MailmanAPIError:
             pass  # can't determine — proceed and let Mailman handle it on confirm
@@ -279,15 +327,26 @@ def _handle_anonymous(self, request, email, list_id):
             _send_confirmation_email(request, email, None, [list_id])
         except Exception as exc:
             logger.error("Failed to send confirmation email to %s: %s", email, exc)
-            return self._card(
+            if _is_htmx(request):
+                return self._card(
+                    request,
+                    state="error",
+                    error_message="Could not send confirmation email. Please try again.",
+                    user_email=email,
+                    list_id=list_id,
+                )
+            return _prg_redirect(
                 request,
-                state="error",
-                error_message="Could not send confirmation email. Please try again.",
-                user_email=email,
-                list_id=list_id,
+                ml_state="error",
+                ml_error="Could not send confirmation email. Please try again.",
+                ml_email=email,
             )
 
-        return self._card(request, state="pending", user_email=email, list_id=list_id)
+        if _is_htmx(request):
+            return self._card(
+                request, state="pending", user_email=email, list_id=list_id
+            )
+        return _prg_redirect(request, ml_state="pending", ml_email=email)
 
 
 class ConfirmSubscriptionView(View):

templates/v3/community.html

@@ -38,7 +38,7 @@
             {% include "v3/includes/_post_card.html" with heading="Posts from the Boost community" items=posts variant="card" theme="teal" primary_cta_label="View all posts" primary_cta_url=news_url %}
           </div>
           <div class="community-masonry__cell community-masonry__cell--mailing">
-            {% include "v3/includes/_mailing_list_card.html" with subscribe_url=mailing_list_card_subscribe_url list_id=mailing_list_card_list_id state=mailing_list_card_state user_email=mailing_list_card_user_email manage_url=mailing_list_card_manage_url subscription_count=mailing_list_card_subscription_count %}
+            {% include "v3/includes/_mailing_list_card.html" with subscribe_url=mailing_list_card_subscribe_url list_id=mailing_list_card_list_id state=mailing_list_card_state user_email=mailing_list_card_user_email manage_url=mailing_list_card_manage_url subscription_count=mailing_list_card_subscription_count error_message=mailing_list_card_error_message %}
           </div>
         </div>
       </div>

templates/v3/includes/_mailing_list_card.html

@@ -38,6 +38,8 @@
     </div>
     <hr class="card__hr" />
     <form
+      action="{{ subscribe_url }}"
+      method="post"
       class="mailing-list-card__form"
       hx-post="{{ subscribe_url }}"
       hx-target="closest .basic-card"

templates/v3/learn_page.html

@@ -49,7 +49,7 @@ <h1>Start anywhere. Learn everything. Build anything.</h1>
         {% endwith %}
       </div>
       <div class="item-e">
-        {% include 'v3/includes/_mailing_list_card.html' with subscribe_url=mailing_list_card_subscribe_url list_id=mailing_list_card_list_id state=mailing_list_card_state user_email=mailing_list_card_user_email manage_url=mailing_list_card_manage_url subscription_count=mailing_list_card_subscription_count %}
+        {% include 'v3/includes/_mailing_list_card.html' with subscribe_url=mailing_list_card_subscribe_url list_id=mailing_list_card_list_id state=mailing_list_card_state user_email=mailing_list_card_user_email manage_url=mailing_list_card_manage_url subscription_count=mailing_list_card_subscription_count error_message=mailing_list_card_error_message %}
       </div>
     </div>
   </div>

templates/v3/libraries/library-subpage.html

@@ -53,7 +53,7 @@
         {% include "v3/includes/_post_card.html" with heading="Latest "|add:object.display_name|add:" posts" items=library_posts variant="card" theme="teal" layout="horizontal" primary_cta_label="View all posts" primary_cta_url="/news/" %}
       </div>
       <div class="item-b">
-        {% include "v3/includes/_mailing_list_card.html" with subscribe_url=mailing_list_card_subscribe_url list_id=mailing_list_card_list_id state=mailing_list_card_state user_email=mailing_list_card_user_email manage_url=mailing_list_card_manage_url subscription_count=mailing_list_card_subscription_count %}
+        {% include "v3/includes/_mailing_list_card.html" with subscribe_url=mailing_list_card_subscribe_url list_id=mailing_list_card_list_id state=mailing_list_card_state user_email=mailing_list_card_user_email manage_url=mailing_list_card_manage_url subscription_count=mailing_list_card_subscription_count error_message=mailing_list_card_error_message %}
       </div>
     </div>
 

templates/v3/release_detail.html

@@ -34,7 +34,7 @@
     {% endif %}
 
     <section class="release-detail__bottom-cards" aria-label="Community and resources">
-      {% include "v3/includes/_mailing_list_card.html" with subscribe_url=mailing_list_card_subscribe_url list_id=mailing_list_card_list_id state=mailing_list_card_state user_email=mailing_list_card_user_email manage_url=mailing_list_card_manage_url subscription_count=mailing_list_card_subscription_count %}
+      {% include "v3/includes/_mailing_list_card.html" with subscribe_url=mailing_list_card_subscribe_url list_id=mailing_list_card_list_id state=mailing_list_card_state user_email=mailing_list_card_user_email manage_url=mailing_list_card_manage_url subscription_count=mailing_list_card_subscription_count error_message=mailing_list_card_error_message %}
 
       {% include "v3/includes/_basic_card.html" with title="Want to fix bugs, review code, maintain libraries, and propose new features?" text="Read our contributors guide and join the Boost community." primary_button_url="/contribute" primary_button_label="Start here" primary_button_style="green" theme="green" only %}
       {% large_static 'img/v3/home-page/heros.png' as image_url %}