Skip to content

Commit edfad5d

Browse files
committed
PR feedback
1 parent ba59457 commit edfad5d

4 files changed

Lines changed: 8 additions & 4 deletions

File tree

core/views.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
from django.views import View
3030
from django.views.decorators.cache import never_cache
3131
from django.views.generic import TemplateView
32+
from waffle import flag_is_active
3233

3334
from core.templatetags.custom_static import large_static
3435
from config.settings import ENABLE_DB_CACHE
@@ -133,6 +134,10 @@ class CommunityView(V3Mixin, TemplateView):
133134
v3_template_name = "v3/community.html"
134135

135136
def dispatch(self, request, *args, **kwargs):
137+
response = super().dispatch(request, *args, **kwargs)
138+
if not flag_is_active(request, "v3"):
139+
return response
140+
136141
version_slug = self.kwargs.get("version_slug")
137142
if not version_slug:
138143
version_data = context_processors.selected_version(self.request)
@@ -142,7 +147,6 @@ def dispatch(self, request, *args, **kwargs):
142147
else LATEST_RELEASE_URL_PATH_STR
143148
)
144149
return redirect("community-version", version_slug=target)
145-
response = super().dispatch(request, *args, **kwargs)
146150
if version_slug != LATEST_RELEASE_URL_PATH_STR:
147151
set_selected_boost_version(version_slug, response)
148152
return response

libraries/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ class LibraryListBase(BoostVersionMixin, V3Mixin, VersionAlertMixin, ListView):
125125
v3_template_name = "v3/library_page.html"
126126

127127
def get_v3_context_data(self, queryset=None, **kwargs):
128-
queryset = self.get_queryset()
128+
queryset = getattr(self, "object_list") or []
129129
context = super().get_v3_context_data(**kwargs)
130130
view_str = self.kwargs.get("library_view_str")
131131

static/css/v3/auth-page.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ body:has(.auth-page) .header {
176176
.auth-page__sign-in-link a{
177177
text-decoration: underline;
178178
color: var(--color-text-link-accent);
179-
font-weight: var(--font-weight-regular);
179+
font-weight: var(--font-weight-medium);
180180
}
181181

182182
/* ── Divider ───────────────────────────────── */

static/css/v3/forms.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@
643643

644644
.checkbox__label a {
645645
text-decoration: underline;
646-
font-weight: var(--font-weight-regular);
646+
font-weight: var(--font-weight-medium);
647647
color: var(--color-text-link-accent);
648648
}
649649

0 commit comments

Comments
 (0)