libvirt: Add creation timestamp to base disks output

Because it's useful to know.

Signed-off-by: Colin Walters <walters@verbum.org>

Author: cgwalters

Cargo.lock

@@ -31,3 +31,4 @@ libtest-mimic = "0.7.3"
 tempfile = "3"
 uuid = { version = "1.18.1", features = ["v4"] }
 camino = "1.1.12"
+regex = "1"

crates/integration-tests/Cargo.toml

@@ -299,6 +299,10 @@ fn main() {
             tests::libvirt_base_disks::test_base_disks_list_command();
             Ok(())
         }),
+        Trial::test("libvirt_base_disks_list_shows_timestamp", || {
+            tests::libvirt_base_disks::test_base_disks_list_shows_timestamp();
+            Ok(())
+        }),
         Trial::test("libvirt_base_disks_prune_dry_run", || {
             tests::libvirt_base_disks::test_base_disks_prune_dry_run();
             Ok(())

crates/integration-tests/src/main.rs

@@ -9,6 +9,7 @@
 use std::process::Command;
 
 use crate::{get_bck_command, get_test_image, run_bcvk};
+use regex::Regex;
 
 /// Test that base disk is created and reused for multiple VMs
 pub fn test_base_disk_creation_and_reuse() {
@@ -131,6 +132,75 @@ pub fn test_base_disks_list_command() {
     }
 }
 
+/// Test base-disks list shows creation timestamp
+pub fn test_base_disks_list_shows_timestamp() {
+    let test_image = get_test_image();
+    let bck = get_bck_command().unwrap();
+
+    println!("Testing base-disks list shows creation timestamp");
+
+    let timestamp = std::time::SystemTime::now()
+        .duration_since(std::time::UNIX_EPOCH)
+        .unwrap()
+        .as_secs();
+    let vm_name = format!("test-base-timestamp-{}", timestamp);
+
+    cleanup_domain(&vm_name);
+
+    // Create a VM to ensure we have at least one base disk
+    println!("Creating VM to generate base disk...");
+    let vm_output = run_bcvk(&[
+        "libvirt",
+        "run",
+        "--name",
+        &vm_name,
+        "--filesystem",
+        "ext4",
+        &test_image,
+    ])
+    .expect("Failed to create VM");
+
+    if !vm_output.success() {
+        cleanup_domain(&vm_name);
+        panic!("Failed to create VM: {}", vm_output.stderr);
+    }
+
+    // Run base-disks list
+    let output = Command::new(&bck)
+        .args(["libvirt", "base-disks", "list"])
+        .output()
+        .expect("Failed to run base-disks list");
+
+    let stdout = String::from_utf8_lossy(&output.stdout);
+    let stderr = String::from_utf8_lossy(&output.stderr);
+
+    cleanup_domain(&vm_name);
+
+    if output.status.success() {
+        println!("base-disks list output:\n{}", stdout);
+
+        // Should have CREATED column in header
+        assert!(
+            stdout.contains("CREATED"),
+            "Should show CREATED column in header"
+        );
+
+        // Should show timestamp values (either a date or "unknown")
+        // Timestamp format is YYYY-MM-DD HH:MM
+        let re = Regex::new(r"\d{4}-\d{2}-\d{2} \d{2}:\d{2}|unknown").unwrap();
+        let has_timestamp = re.is_match(&stdout);
+        assert!(
+            has_timestamp,
+            "Should show timestamp values in CREATED column"
+        );
+
+        println!("✓ base-disks list shows creation timestamp");
+    } else {
+        println!("base-disks list failed: {}", stderr);
+        panic!("Failed to run base-disks list: {}", stderr);
+    }
+}
+
 /// Test base-disks prune command with dry-run
 pub fn test_base_disks_prune_dry_run() {
     let bck = get_bck_command().unwrap();

crates/integration-tests/src/tests/libvirt_base_disks.rs

@@ -320,8 +320,10 @@ pub fn list_base_disks(connect_uri: Option<&str>) -> Result<Vec<BaseDiskInfo>> {
                         )
                         .unwrap_or(None);
 
-                    // Get file size
-                    let size = entry.metadata().ok().map(|m| m.len());
+                    // Get file size and creation time
+                    let metadata = entry.metadata().ok();
+                    let size = metadata.as_ref().map(|m| m.len());
+                    let created = metadata.and_then(|m| m.created().ok());
 
                     // Count references
                     let ref_count = count_base_disk_references(&path, &vm_disks)?;
@@ -331,6 +333,7 @@ pub fn list_base_disks(connect_uri: Option<&str>) -> Result<Vec<BaseDiskInfo>> {
                         image_digest,
                         size,
                         ref_count,
+                        created,
                     });
                 }
             }
@@ -347,6 +350,7 @@ pub struct BaseDiskInfo {
     pub image_digest: Option<String>,
     pub size: Option<u64>,
     pub ref_count: usize,
+    pub created: Option<std::time::SystemTime>,
 }
 
 /// Prune unreferenced base disks

crates/kit/src/libvirt/base_disks.rs

@@ -66,7 +66,7 @@ fn run_list(connect_uri: Option<&str>, opts: ListOpts) -> Result<()> {
 
             let mut table = Table::new();
             table.load_preset(UTF8_FULL);
-            table.set_header(vec!["NAME", "SIZE", "REFS", "IMAGE DIGEST"]);
+            table.set_header(vec!["NAME", "SIZE", "REFS", "CREATED", "IMAGE DIGEST"]);
 
             for disk in &base_disks {
                 let name = disk.path.file_name().unwrap_or("unknown");
@@ -78,6 +78,13 @@ fn run_list(connect_uri: Option<&str>, opts: ListOpts) -> Result<()> {
 
                 let refs = disk.ref_count.to_string();
 
+                let created = disk
+                    .created
+                    .and_then(|t| t.duration_since(std::time::UNIX_EPOCH).ok())
+                    .and_then(|d| chrono::DateTime::from_timestamp(d.as_secs() as i64, 0))
+                    .map(|dt| dt.format("%Y-%m-%d %H:%M").to_string())
+                    .unwrap_or_else(|| "unknown".to_string());
+
                 let digest = disk
                     .image_digest
                     .as_ref()
@@ -91,7 +98,7 @@ fn run_list(connect_uri: Option<&str>, opts: ListOpts) -> Result<()> {
                     })
                     .unwrap_or_else(|| "<no metadata>".to_string());
 
-                table.add_row(vec![name, &size, &refs, &digest]);
+                table.add_row(vec![name, &size, &refs, &created, &digest]);
             }
 
             println!("{}", table);