Skip to content

Commit dfd232e

Browse files
committed
tests: Disable broken FCOS libvirt ignition test
FCOS installed via bootc install drops into emergency mode because the partition layout (BIOS boot + EFI + root) lacks the "boot"-labeled partition that coreos-boot-mount-generator expects. The 90-second device wait for /dev/disk/by-label/boot times out, then SSHD never starts and the root account is locked. Ignition itself is also skipped — bootc install marks the disk as provisioned, so FCOS treats every boot as "subsequent." An analogous fix landed for the ephemeral/virtiofs case in coreos/fedora-coreos-config#3859 but the bootc-install-to-disk case is not yet handled upstream. Disable the test registration (keeping the code) until the upstream generator is fixed. The other ignition tests (invalid path, unsupported image) still run and pass. Assisted-by: OpenCode (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
1 parent c8998a0 commit dfd232e

1 file changed

Lines changed: 18 additions & 5 deletions

File tree

crates/integration-tests/src/tests/libvirt_ignition.rs

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,23 @@ fn random_suffix() -> String {
2525
/// Fedora CoreOS image that supports Ignition
2626
const FCOS_IMAGE: &str = "quay.io/fedora/fedora-coreos:stable";
2727

28-
/// Test that Ignition config injection mechanism works for libvirt
28+
/// Test that Ignition config injection mechanism works end-to-end for libvirt.
2929
///
30-
/// This test verifies that the Ignition config injection mechanism is working
31-
/// by checking that the VM can be created with --ignition flag and that the
32-
/// config file is properly stored.
30+
/// DISABLED: FCOS installed via `bootc install` drops into emergency mode
31+
/// because the partition layout (BIOS boot + EFI + root) lacks the separate
32+
/// "boot"-labeled partition that FCOS's `coreos-boot-mount-generator` expects.
33+
/// The 90-second device wait for `/dev/disk/by-label/boot` times out, SSHD
34+
/// never starts, and the root account is locked. Additionally, Ignition
35+
/// itself is skipped — `bootc install` marks the disk as already provisioned,
36+
/// so FCOS treats every boot as "subsequent."
37+
///
38+
/// The upstream fix (extending `coreos-boot-mount-generator` to tolerate
39+
/// missing boot partitions for the `bootc install` case, analogous to the
40+
/// virtiofs fix in <https://github.com/coreos/fedora-coreos-config/pull/3859>)
41+
/// has not landed yet. Re-enable this test once it does.
42+
///
43+
/// See also: <https://github.com/coreos/fedora-coreos-config/issues/400>
44+
#[allow(dead_code)]
3345
fn test_libvirt_ignition_works() -> TestResult {
3446
let sh = shell()?;
3547
let bck = get_bck_command()?;
@@ -86,7 +98,8 @@ fn test_libvirt_ignition_works() -> TestResult {
8698
println!("Ignition config injection test passed");
8799
Ok(())
88100
}
89-
integration_test!(test_libvirt_ignition_works);
101+
// DISABLED: see doc comment above for rationale and upstream links.
102+
// integration_test!(test_libvirt_ignition_works);
90103

91104
/// Test that Ignition config validation rejects nonexistent files
92105
fn test_libvirt_ignition_invalid_path() -> TestResult {

0 commit comments

Comments
 (0)