integration-tests: Consolidate tests to reduce disk image creation

The integration tests were creating separate disk images for tests
that could share the same VM, causing unnecessary duplication of
expensive `to-disk` operations.

Changes:
- Merged `test_base_disks_list_shows_timestamp` into
  `test_base_disk_creation_and_reuse` - the timestamp test no longer
  needs its own VM, it can verify the list output after the reuse test
  creates VMs
- Created `test_libvirt_comprehensive_workflow` that consolidates
  multiple separate tests (`test_libvirt_run_list_json_ssh_metadata`,
  `test_libvirt_run_with_instancetype`, and
  `test_libvirt_run_label_functionality`) into a single test that
  creates one VM and verifies:
  - Instance type configuration
  - Label metadata and filtering
  - JSON output with SSH metadata
  - VM lifecycle

This reduces the number of expensive disk image creations in CI,
improving test performance while maintaining the same test coverage.

Assisted-by: Claude Code (Sonnet 4.5)
Signed-off-by: Colin Walters <walters@verbum.org>

Author: cgwalters

crates/integration-tests/src/tests/libvirt_base_disks.rs

@@ -91,6 +91,41 @@ fn test_base_disk_creation_and_reuse() -> Result<()> {
         "Should mention using base disk"
     );
 
+    // Test base-disks list shows creation timestamp
+    println!("Testing that base-disks list shows creation timestamp...");
+    let bck = get_bck_command()?;
+    let list_output = std::process::Command::new(&bck)
+        .args(["libvirt", "base-disks", "list"])
+        .output()
+        .expect("Failed to run base-disks list");
+
+    let list_stdout = String::from_utf8_lossy(&list_output.stdout);
+    let list_stderr = String::from_utf8_lossy(&list_output.stderr);
+
+    if list_output.status.success() {
+        println!("base-disks list output:\n{}", list_stdout);
+
+        // Should have CREATED column in header
+        assert!(
+            list_stdout.contains("CREATED"),
+            "Should show CREATED column in header"
+        );
+
+        // Should show timestamp values (either a date or "unknown")
+        // Timestamp format is YYYY-MM-DD HH:MM
+        let re = Regex::new(r"\d{4}-\d{2}-\d{2} \d{2}:\d{2}|unknown").unwrap();
+        let has_timestamp = re.is_match(&list_stdout);
+        assert!(
+            has_timestamp,
+            "Should show timestamp values in CREATED column"
+        );
+
+        println!("✓ base-disks list shows creation timestamp");
+    } else {
+        println!("base-disks list failed: {}", list_stderr);
+        panic!("Failed to run base-disks list: {}", list_stderr);
+    }
+
     println!("✓ Base disk creation and reuse test passed");
     Ok(())
 }
@@ -137,76 +172,6 @@ fn test_base_disks_list_command() -> Result<()> {
 }
 integration_test!(test_base_disks_list_command);
 
-/// Test base-disks list shows creation timestamp
-fn test_base_disks_list_shows_timestamp() -> Result<()> {
-    let test_image = get_test_image();
-    let bck = get_bck_command()?;
-
-    println!("Testing base-disks list shows creation timestamp");
-
-    let timestamp = std::time::SystemTime::now()
-        .duration_since(std::time::UNIX_EPOCH)
-        .unwrap()
-        .as_secs();
-    let vm_name = format!("test-base-timestamp-{}", timestamp);
-
-    cleanup_domain(&vm_name);
-
-    // Create a VM to ensure we have at least one base disk
-    println!("Creating VM to generate base disk...");
-    let vm_output = run_bcvk(&[
-        "libvirt",
-        "run",
-        "--name",
-        &vm_name,
-        "--filesystem",
-        "ext4",
-        &test_image,
-    ])?;
-
-    if !vm_output.success() {
-        cleanup_domain(&vm_name);
-        panic!("Failed to create VM: {}", vm_output.stderr);
-    }
-
-    // Run base-disks list
-    let output = Command::new(&bck)
-        .args(["libvirt", "base-disks", "list"])
-        .output()
-        .expect("Failed to run base-disks list");
-
-    let stdout = String::from_utf8_lossy(&output.stdout);
-    let stderr = String::from_utf8_lossy(&output.stderr);
-
-    cleanup_domain(&vm_name);
-
-    if output.status.success() {
-        println!("base-disks list output:\n{}", stdout);
-
-        // Should have CREATED column in header
-        assert!(
-            stdout.contains("CREATED"),
-            "Should show CREATED column in header"
-        );
-
-        // Should show timestamp values (either a date or "unknown")
-        // Timestamp format is YYYY-MM-DD HH:MM
-        let re = Regex::new(r"\d{4}-\d{2}-\d{2} \d{2}:\d{2}|unknown").unwrap();
-        let has_timestamp = re.is_match(&stdout);
-        assert!(
-            has_timestamp,
-            "Should show timestamp values in CREATED column"
-        );
-
-        println!("✓ base-disks list shows creation timestamp");
-    } else {
-        println!("base-disks list failed: {}", stderr);
-        panic!("Failed to run base-disks list: {}", stderr);
-    }
-    Ok(())
-}
-integration_test!(test_base_disks_list_shows_timestamp);
-
 /// Test base-disks prune command with dry-run
 fn test_base_disks_prune_dry_run() -> Result<()> {
     let bck = get_bck_command()?;