Skip to content

to-disk: Always --skip-fetch-check#24

Merged
cgwalters merged 1 commit into
bootc-dev:mainfrom
cgwalters:always-skip-fetch
Sep 24, 2025
Merged

to-disk: Always --skip-fetch-check#24
cgwalters merged 1 commit into
bootc-dev:mainfrom
cgwalters:always-skip-fetch

Conversation

@cgwalters
Copy link
Copy Markdown
Collaborator

So things work with older images too; I wanted to test something in RHEL 9.5 (EOL today) but still useful to cross check.

So things work with older images too; I wanted to test something
in RHEL 9.5 (EOL today) but still useful to cross check.

Signed-off-by: Colin Walters <walters@verbum.org>
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the to-disk utility to always include the --skip-fetch-check argument. This change is crucial for maintaining compatibility with older image versions, enabling testing and operations on systems like RHEL 9.5, where this flag might not be implicitly handled.

Highlights

  • to-disk command: The --skip-fetch-check flag is now unconditionally added to the to-disk command arguments. This ensures compatibility when working with older image versions, as the flag is a default in newer versions but needs to be explicitly added for older ones.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the --skip-fetch-check flag to the bootc install to-disk command to improve compatibility with older versions of bootc. The change is straightforward, includes a clear comment explaining its purpose, and is correctly implemented. This is a good enhancement for ensuring the tool works across different environments. I have reviewed the change and have no suggestions for improvement.

@cgwalters cgwalters enabled auto-merge (squash) September 24, 2025 19:37
@cgwalters cgwalters merged commit 1384826 into bootc-dev:main Sep 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants