libvirt: Support --connect globally

[cgwalters]

We really want this for all options consistently, so move it to be part of the libvirt verb and passed down to each sub-option.

[gemini-code-assist]

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the handling of libvirt connection URIs by centralizing the --connect option. Instead of each libvirt subcommand managing its own connection parameter, a global LibvirtOptions struct now holds this information, which is then passed down to all relevant functions. This change improves consistency, reduces redundancy, and simplifies the command-line interface for libvirt operations.

Highlights

• Centralized Libvirt Connection Handling: The --connect option for specifying the Hypervisor connection URI has been moved from individual libvirt subcommands to a global option for the top-level libvirt command. This ensures consistent connection handling across all libvirt operations.
• Refactored Libvirt Command Structure: A new LibvirtOptions struct was introduced to encapsulate the global connection URI. All libvirt subcommand functions (create, inspect, list, list_volumes, rm, run, ssh, start, stop, upload) now accept this LibvirtOptions struct, streamlining the virsh command execution.
• Updated CLI and Documentation: The command-line interface in main.rs was updated to reflect the global --connect option. Corresponding man pages for bcvk-libvirt and its subcommands have been adjusted to document this change.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully refactors the libvirt subcommands to support a global --connect option. The changes are well-structured, moving the connection logic to a central LibvirtOptions struct and updating all subcommands to use it. This greatly improves consistency. My review includes a few suggestions to further improve maintainability by removing some proxy methods and refactoring a function with duplicated logic. Overall, this is a solid improvement.

[jeckersb]

LGTM, needs rebase though