More virtiofs#67
Closed
cgwalters wants to merge 8 commits into
Closed
Conversation
ee1adee to
9d3f1cc
Compare
Otherwise we are subject to hit FD exhaustion. See bootc-dev#65 Signed-off-by: Colin Walters <walters@verbum.org>
Don't pretend we can configure it. Signed-off-by: Colin Walters <walters@verbum.org>
Switch VirtiofsConfig to use Utf8PathBuf instead of String for socket_path and shared_dir fields. This provides better type safety for filesystem paths and matches the camino conventions used elsewhere in the codebase. Signed-off-by: Colin Walters <walters@verbum.org>
Add --readonly flag to virtiofsd and rootflags=ro to the kernel command line. Since we use systemd.volatile=overlay, the guest has a writable overlay on top, so there's no need for virtiofsd to support writes. This provides an additional layer of safety. Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: Colin Walters <walters@verbum.org>
9d3f1cc to
ef62b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.