libvirt: Fix memory display unit conversion

[cgwalters]

Fix incorrect memory display in bcvk libvirt list --all

Assisted-by: Claude Code

[gemini-code-assist]

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an inaccuracy in how memory values were displayed by the bcvk libvirt list --all command. Previously, the tool failed to correctly interpret memory units specified in libvirt XML, leading to misleading output. The changes introduce robust unit conversion logic, ensuring that memory is consistently parsed and presented in megabytes, thereby enhancing the reliability and user-friendliness of the bcvk tool's virtual machine listing capabilities.

Highlights

• Memory Display Fix: Corrected an issue where the bcvk libvirt list --all command displayed incorrect memory values, such as '4194304MB' instead of '4096MB'.
• Unit Conversion: Implemented proper unit conversion for libvirt XML memory elements, supporting various units like KiB, MiB, and GiB.
• Reusable Helpers: Introduced a reusable convert_memory_to_mb() helper function and an XmlNode::parse_memory_mb() method to standardize memory parsing and conversion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly identifies and fixes an issue with memory unit conversion from libvirt XML. The approach of creating a dedicated helper function is good. However, the implementation of the conversion logic has some correctness issues regarding the distinction between decimal and binary memory units as specified by libvirt. I've provided suggestions to fix this, improve robustness, and enhance test coverage to ensure the feature is working as expected.