Move memory conversion helpers to libvirt module

[cgwalters]

The module structure was twisted and this caused dead_code they belong, as these are libvirt-specific helpers for parsing libvirt domain XML memory specifications, not generic XML utilities.

Assisted-by: Claude Code

[gemini-code-assist]

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the codebase by relocating libvirt-specific memory parsing and conversion utilities. The goal is to enhance the logical grouping of code, ensuring that functions directly related to libvirt XML processing reside within the dedicated libvirt module, thereby improving maintainability and code clarity.

Highlights

• Code Relocation: The memory conversion helper functions, convert_memory_to_mb and parse_memory_mb, have been moved from generic utility modules to the libvirt module.
• Improved Module Structure: This change clarifies that these helpers are specific to parsing libvirt domain XML memory specifications, improving the overall module organization and removing previously 'dead_code' due to twisted module structure.
• Dependency Update: Call sites for parse_memory_mb in domain_list.rs have been updated to reflect the new location of the function within the libvirt module.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that moves libvirt-specific memory conversion helpers from a general utility module to the more appropriate libvirt module. This improves code organization and modularity. I've identified a critical issue related to a potential integer overflow that could lead to incorrect memory calculations, along with a few suggestions to improve code maintainability.

[jmarrero]

code lgtm but CI is not happy

[cgwalters]

Yeah my bad for trying to fix this manually, after chatting with an agent the issue became more obvious (I thought it was just validate failing).