Skip to content

Make the bootc image point to the public image#42

Merged
alicefr merged 1 commit into
mainfrom
fix-node-image-reference
Jun 3, 2026
Merged

Make the bootc image point to the public image#42
alicefr merged 1 commit into
mainfrom
fix-node-image-reference

Conversation

@alicefr

@alicefr alicefr commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Tag the image with the public registry. In this way, the image embedded in the bootc disk image now points to:

bootc status
● Booted image: ghcr.io/alicefr/bink/bink-node:v1.35-fedora-44
Digest: sha256:b1dd0021b320fd9220749c43faee982c83592af501b2b74d5e87607ec77dbe39 (amd64)
Timestamp: 2026-06-03T11:47:46Z

Summary by Sourcery

Update Fedora node image Makefile to publish bootc and disk images to a configurable public container registry instead of a local one.

Enhancements:

  • Introduce a REGISTRY variable defaulting to the public ghcr.io/alicefr/bink registry for image references in the Fedora node image Makefile.

Build:

  • Change BOOTC_IMAGE and NODE_IMAGE tags to use the configurable public REGISTRY rather than localhost for built images.

Tag the image with the public registry. In this way, the image
embedded in the bootc disk image now points to:

bootc status
● Booted image: ghcr.io/alicefr/bink/bink-node:v1.35-fedora-44
        Digest: sha256:b1dd0021b320fd9220749c43faee982c83592af501b2b74d5e87607ec77dbe39 (amd64)
     Timestamp: 2026-06-03T11:47:46Z

Signed-off-by: Alice Frosi <afrosi@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the Fedora node image Makefile so that bootc and disk images are built and tagged against a configurable public registry (defaulting to ghcr.io/alicefr/bink) instead of localhost, ensuring the embedded bootc image in the disk points to a publicly accessible image.

File-Level Changes

Change Details Files
Make Fedora node bootc and disk images tag against a configurable public registry instead of localhost.
  • Introduce a REGISTRY Makefile variable defaulting to ghcr.io/alicefr/bink.
  • Change BOOTC_IMAGE to use $(REGISTRY)/bink-node:$(IMAGE_TAG).
  • Change NODE_IMAGE to use $(REGISTRY)/bink-node:$(IMAGE_TAG)-disk.
node-images/fedora/Makefile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Changing the default from localhost to ghcr.io will break any local-only workflows that relied on the previous default; consider keeping the default as localhost and using REGISTRY only when explicitly overridden (e.g., via environment or higher-level config) for publishing.
  • If the intent is specifically to make only the embedded bootc image public, consider separating the registry configuration for BOOTC_IMAGE and NODE_IMAGE so that the disk image can remain locally tagged if desired.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Changing the default from localhost to ghcr.io will break any local-only workflows that relied on the previous default; consider keeping the default as localhost and using REGISTRY only when explicitly overridden (e.g., via environment or higher-level config) for publishing.
- If the intent is specifically to make only the embedded bootc image public, consider separating the registry configuration for BOOTC_IMAGE and NODE_IMAGE so that the disk image can remain locally tagged if desired.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@alicefr alicefr merged commit 69bacc1 into main Jun 3, 2026
6 checks passed
@alicefr alicefr deleted the fix-node-image-reference branch June 18, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant