Make the bootc image point to the public image#42
Merged
Conversation
Tag the image with the public registry. In this way, the image
embedded in the bootc disk image now points to:
bootc status
● Booted image: ghcr.io/alicefr/bink/bink-node:v1.35-fedora-44
Digest: sha256:b1dd0021b320fd9220749c43faee982c83592af501b2b74d5e87607ec77dbe39 (amd64)
Timestamp: 2026-06-03T11:47:46Z
Signed-off-by: Alice Frosi <afrosi@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate the Fedora node image Makefile so that bootc and disk images are built and tagged against a configurable public registry (defaulting to ghcr.io/alicefr/bink) instead of localhost, ensuring the embedded bootc image in the disk points to a publicly accessible image. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Changing the default from localhost to ghcr.io will break any local-only workflows that relied on the previous default; consider keeping the default as localhost and using REGISTRY only when explicitly overridden (e.g., via environment or higher-level config) for publishing.
- If the intent is specifically to make only the embedded bootc image public, consider separating the registry configuration for BOOTC_IMAGE and NODE_IMAGE so that the disk image can remain locally tagged if desired.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Changing the default from localhost to ghcr.io will break any local-only workflows that relied on the previous default; consider keeping the default as localhost and using REGISTRY only when explicitly overridden (e.g., via environment or higher-level config) for publishing.
- If the intent is specifically to make only the embedded bootc image public, consider separating the registry configuration for BOOTC_IMAGE and NODE_IMAGE so that the disk image can remain locally tagged if desired.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag the image with the public registry. In this way, the image embedded in the bootc disk image now points to:
bootc status
● Booted image: ghcr.io/alicefr/bink/bink-node:v1.35-fedora-44
Digest: sha256:b1dd0021b320fd9220749c43faee982c83592af501b2b74d5e87607ec77dbe39 (amd64)
Timestamp: 2026-06-03T11:47:46Z
Summary by Sourcery
Update Fedora node image Makefile to publish bootc and disk images to a configurable public container registry instead of a local one.
Enhancements:
Build: