Support 1.34 and 1.36 kubernetes version #76
Open
alicefr wants to merge 3 commits into
Open
Conversation
The bootc-operator needs to be tested on the active kubernetes version. Hence, we need to publish the relative k8s images. See: bootc-dev/bootc-operator#48 Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
Integration tests were hardcoded to config.DefaultNodeImage (v1.35). To test against other K8s versions, add a NodeImage() helper that reads BINK_NODE_IMAGE and wire it into all cluster creation paths. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
For now, let's keep 1.25 as the standard the let's swap 1.35 with 1.36 once it has been tested. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
jlebon
reviewed
Jun 26, 2026
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| kube-minor: ['1.34', '1.35', '1.36'] |
Collaborator
There was a problem hiding this comment.
Tooootally not a blocker here but would be cool to use e.g. https://endoflife.date/api/kubernetes.json and dynamically create the matrix here for all supported Kubernetes versions.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| kube-minor: ['1.34', '1.36'] |
Collaborator
There was a problem hiding this comment.
And here as well.
Otherwise, bumping this every quarter is going to get tiring. :)
Collaborator
There was a problem hiding this comment.
Shouldn't we extend https://github.com/bootc-dev/bink/blob/main/.github/workflows/integration-tests.yml instead to avoid duplicating?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build and run some smoke test on node image based on kubernetes 1.34 and 1.36. This is required by the bootc-operator by bootc-dev/bootc-operator#48