Skip to content

Commit dc56644

Browse files
committed
Makefile: use :latest tag for pushed bink image
This is subtle but by having the tag be `:latest`, K8s will use a default of `Always` for the image pull policy: https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting (We don't specify an explicit `imagePullPolicy` in our configs. We may do that in the future, though there's trade-offs there to think about. I think it depends a lot on the packaging/productization layers once we get there. But I think the K8s defaults mostly make sense.)
1 parent 9890452 commit dc56644

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

Makefile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,13 @@ undeploy: kustomize ## Undeploy controller from the K8s cluster specified in ~/.
105105
"$(KUSTOMIZE)" build config/default | "$(KUBECTL)" delete --ignore-not-found=$(ignore-not-found) -f -
106106

107107
# In-cluster image used by deploy-bink after pushing to the bink registry.
108-
IMG_BINK ?= registry.cluster.local:5000/bootc-operator:e2e
108+
# Note the :latest tag here: this makes the pull policy be Always.
109+
IMG_BINK ?= registry.cluster.local:5000/bootc-operator-e2e:latest
109110

110111
.PHONY: deploy-bink
111-
deploy-bink: kustomize ## Deploy to a bink cluster (idempotent).
112+
deploy-bink: kustomize ## Deploy to a bink cluster (idempotent, requires: buildimg).
112113
bink registry start
113-
podman push --tls-verify=false $(IMG) localhost:5000/bootc-operator:e2e
114+
podman push --tls-verify=false $(IMG) localhost:5000/bootc-operator-e2e:latest
114115
bink cluster list 2>&1 | grep -qw $(BINK_CLUSTER_NAME) || \
115116
bink cluster start --cluster-name $(BINK_CLUSTER_NAME) --node-name controller --api-port 0 --expose $(KUBECONFIG_BINK) \
116117
$(if $(BINK_NODE_IMAGE),--node-image $(BINK_NODE_IMAGE))

0 commit comments

Comments
 (0)