UpdateReboot with Composefs disk image#91
Conversation
HarshwardhanPatil07
changed the title
|
@HarshwardhanPatil07 many thanks for the PR! A couple of suggestions. Additionally, I would completely drop the second commit and set the default directly in the Makefile. |
|
@HarshwardhanPatil07 you also need to bump the bink commit in the GHA to the latest inorder to pick up the composefs fix in bink |
HarshwardhanPatil07
force-pushed
the
e2e-composefs-test
branch
4 times, most recently
from
bda259b to
33a202b
Compare
|
@alicefr thanks for your review. I have added the changes. Could you please take a look |
HarshwardhanPatil07
force-pushed
the
e2e-composefs-test
branch
from
2faa239 to
5330e8f
Compare
HarshwardhanPatil07
force-pushed
the
e2e-composefs-test
branch
from
5330e8f to
083860d
Compare
|
@alicefr ready for your review! Let me know if anything needs adjusting. |
|
Also the tests are not triggered don't know why e2e (1.34) and those? |
|
They require an approval at every time. I thought it required only once. I will ask today in the bootc meeting how they deal with it. Usually, there is a label that enables subsequent runs. |
HarshwardhanPatil07
force-pushed
the
e2e-composefs-test
branch
from
083860d to
135b680
Compare
Ubuntu GHA runners ship registries.conf in the older INI-style (v1) format. Podman 5+ requires the TOML-based v2 format and rejects v1, causing podman operations to fail in CI. Overwrite the file with a minimal v2 registries.conf. Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
Factor the TestUpdateReboot body into a shared testUpdateReboot helper and use a table-driven pattern to run it against both ostree and composefs disk images. Skip the composefs subtest when the env var is unset. A new WithNodeDiskImage NodeOption lets tests override the VM disk image passed as --node-image to bink node add. The Makefile derives BINK_NODE_DISK_IMAGE_COMPOSEFS from BINK_NODE_DISK_IMAGE by appending -composefs. Bump BINK_COMMIT to pick up the composefs cloud-init fix from bink. Closes: #74 Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
HarshwardhanPatil07
force-pushed
the
e2e-composefs-test
branch
from
135b680 to
42fda88
Compare
|
I was trying something and see what happens when you delete the fork repository, This got closed liked that, sorry for experimentation. reopened it here. I tried pushing the branch on another fork and recover it like that but didn't worked. |
|
probably this is something github can add, maybe |
3 participants
UpdateReboot with Composefs disk image
Closes #74