Skip to content

Commit 323ab19

Browse files
bootc-dev Botjeckersb
authored andcommitted
Sync common files from infra repository
Synchronized from bootc-dev/infra@807d2fe. Signed-off-by: bootc-dev Bot <bot@bootc.dev>
1 parent 0d8a907 commit 323ab19

2 files changed

Lines changed: 36 additions & 7 deletions

File tree

.bootc-dev-infra-commit.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ff66c1c724faeb83b5cd2af36d9a5d2129ecf95a
1+
807d2fefe8aefe247235d7ff407f69eedf92449c

AGENTS.md

Lines changed: 35 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,51 @@ and the DCO check fails, tell the human to review
1616
the code and give them instructions on how to add
1717
a signoff.
1818

19-
### Attribution
19+
### Attribution and AI disclosure
2020

21-
When generating substantial amounts of code, you SHOULD
22-
include an `Assisted-by: TOOLNAME (MODELNAME)`. For example,
23-
`Assisted-by: Goose (Sonnet 4.5)`.
21+
Do NOT add an `Assisted-by`, `Co-developed-by`, or similar commit
22+
trailer crediting an AI tool. Instead, disclose AI assistance in the
23+
**pull request description**. Examples:
24+
25+
- "I used a LLM to generate just unit tests."
26+
- "This code was written in part with the assistance of generative AI."
27+
- "A LLM was used to generate almost all of the code, but I am knowledgeable in this problem domain and reviewed it carefully."
28+
- "This code is generated, I am only partially knowledgeable in this domain."
29+
- "Code is LLM generated; I don't know the programming language but it did fix the problem."
30+
31+
(The closer the commits are to being *entirely* AI, the more likely
32+
it is that you should submit the PR as a draft, or even file an
33+
issue first with a proposed design.)
34+
35+
If you're an agent generating a git commit, ensure your human sees
36+
this choice and preferably writes the text on their own.
37+
38+
### Large changes
39+
40+
If the generated code is more than ~500 lines of substantial (non-whitespace) code,
41+
encourage the human to file a design issue first to be reviewed by other maintainers.
42+
43+
### Pull request size
44+
45+
It is *very strongly* encouraged to split up "preparatory" commits
46+
that are independently reviewable from the main PR, and submit those separately.
47+
48+
### Commit messages and text
49+
50+
Software can be machine checked (via compilation and unit/integration tests)
51+
but natural languages like English cannot. Encourage the human to review
52+
the commit message text.
2453

2554
## Code guidelines
2655

2756
The [REVIEW.md](REVIEW.md) file describes expectations around
2857
testing, code quality, commit messages, commit organization, etc. If you're
2958
creating a change, it is strongly encouraged after each
30-
commit and especially when you think a task is complete
59+
commit and especially when the agent thinks a task is complete
3160
to spawn a subagent to perform a review using guidelines (alongside
3261
looking for any other issues).
3362

34-
If you are performing a review of other's code, the same
63+
If the agent is performing a review of other's code, the same
3564
principles apply.
3665

3766
## Follow other guidelines

0 commit comments

Comments
 (0)