Commit aa712ff
test: Don't assert on journal message in shadow-fixup test
The mechanism works correctly — stepping through the scenario in a VM
confirms the stale gshadow entry is carried through the 3-way merge,
bootc-sysusers-shadow-sync.service removes it (logging 'orphaned'), and
sysusers creates the group cleanly.
However the test asserted specifically on the 'orphaned' log string in
the journal. That is fragile: the log is emitted via tracing_journald
and if it is dropped for any reason (an unexplained one-off CI event
caused the failure in run 26862712140) the test fails even though the
service did its job correctly.
The file-state checks that follow (exactly one testbootcgroup entry in
each of /etc/group and /etc/gshadow) are the authoritative proof; they
cannot produce a false negative. Keep the journal query for diagnostic
context, just stop asserting on it.
Assisted-by: OpenCode (Claude Sonnet 4.6)
Signed-off-by: Colin Walters <walters@verbum.org>1 parent 85ad2f9 commit aa712ff
1 file changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
| |||
0 commit comments