Release 1.4.0#1374
Conversation
Signed-off-by: John Eckersberg <jeckersb@redhat.com>
There was a problem hiding this comment.
Code Review
This pull request updates the version of the bootc-lib crate from 1.3.0 to 1.4.0 in lib/Cargo.toml and consequently in Cargo.lock. These changes are consistent with the PR title "Release 1.4.0" and appear correct for a version bump.
For future consideration to enhance clarity and maintainability (medium severity): the cli crate's Cargo.toml (located at cli/Cargo.toml, which is not part of this PR's changes) declares its dependency on bootc-lib with version = "1.0" (i.e., bootc-lib = { version = "1.0", path = "../lib" }). While Cargo correctly resolves path dependencies to use the actual version from the local path (1.4.0 after this PR), having this declared version differ significantly from bootc-lib's actual version could be confusing for developers. Aligning this declared version (e.g., to "1.4.0"), or using a common placeholder like "*" or "=1.4.0" for path dependencies, might improve consistency. Since bootc-lib is not published to crates.io (as noted by a comment in lib/Cargo.toml) and the cli crate also has publish = false, this is not a functional issue but a point of potential minor confusion.
Signed-off-by: John Eckersberg jeckersb@redhat.com