Skip to content

Rework utils and blockdev crates as -internals in prep for publishing#1394

Merged
cgwalters merged 1 commit into
bootc-dev:mainfrom
cgwalters:publish-internals
Jul 8, 2025
Merged

Rework utils and blockdev crates as -internals in prep for publishing#1394
cgwalters merged 1 commit into
bootc-dev:mainfrom
cgwalters:publish-internals

Conversation

@cgwalters
Copy link
Copy Markdown
Collaborator

See coreos/bootupd#963

Basically I just want a way to keep these in sync with bootupd; we're not attempting to make a truly public library.

See coreos/bootupd#963

Basically I just want a way to keep these in sync with bootupd;
we're not attempting to make a truly public library.

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the bootc-utils and bootc-blockdev crates to be internal-only by renaming them to bootc-internal-utils and bootc-internal-blockdev respectively. This is a preparatory step for publishing other crates in the workspace that depend on them. The changes are confined to Cargo.toml files and Cargo.lock, updating package names and dependency declarations.

Comment thread utils/Cargo.toml
[package]
name = "bootc-utils"
publish = false
name = "bootc-internal-utils"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Clarify the purpose of this crate with a more descriptive description, as this crate is now internal.

description = "Internal implementation component of bootc; do not use"

Copy link
Copy Markdown
Contributor

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuijingHei
Copy link
Copy Markdown
Contributor

The error is not related to this PR, it is infrastructure issue

Errors during downloading metadata for repository 'baseos':
  - Downloading successful, but checksum doesn't match. Calculated:

@cgwalters cgwalters merged commit bb5171b into bootc-dev:main Jul 8, 2025
28 of 34 checks passed
@cgwalters
Copy link
Copy Markdown
Collaborator Author

For the record I published these manually just now via a direct cargo publish. I'm not totally sure in the medium term it will make sense to have these as crates but for now this unblocks coreos/bootupd#964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/system-reinstall-bootc Issues related to system-reinstall-botoc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants