chunking: Support exclusive chunks defined via xattrs#1397
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for exclusive chunks, which allows specific components to be placed in their own layers. The implementation is well-structured, and includes a comprehensive set of new unit tests. Suggestions have been provided to improve code clarity, reduce test code duplication, and strengthen a test assertion.
bd38bb6 to
7f35f22
Compare
cgwalters
left a comment
There was a problem hiding this comment.
This is all very complex code (mostly my fault!) and I find it hard to get it all in my head, but overall this looks reasonable to me.
I think what would really help is seeing this more "end to end" in combination with coreos/rpm-ostree#5431 - especially via a Dockerfile build that sets xattrs and verifies the chunking.
Maybe we could try standing up a CI job that clones your rpm-ostree PR and runs a test job from there? But optional from my PoV right now.
Yep, took me awhile to wrap my head around. Might take a stab at refactoring it a bit after this gets in.
I've been testing locally using this Containerfile (thanks claude) and using my local checkout of bootc in the rpm-ostree Cargo.toml. I can take a stab at doing this in our CI. |
7f35f22 to
4acd5bd
Compare
Signed-off-by: ckyrouac <ckyrouac@redhat.com>
4acd5bd to
81b3c27
Compare
I think it could also live in the rpm-ostree CI and then we just run that job from here, but ultimately it's also fine if it just lives in rpm-ostree I think. Hmm, maybe what could actually make sense is to move the chunking code there instead since there's 0% chance anything else uses it. |
This adds a new "specific_components" parameter to process_mapping to enable mapping individual files to specific layers. This will be used by the rechunker in rpm-ostree.
Related to: coreos/rpm-ostree#5431