Skip to content

build: Add actions to automate release#1429

Merged
ckyrouac merged 1 commit into
bootc-dev:mainfrom
ckyrouac:release-action
Jul 23, 2025
Merged

build: Add actions to automate release#1429
ckyrouac merged 1 commit into
bootc-dev:mainfrom
ckyrouac:release-action

Conversation

@ckyrouac

Copy link
Copy Markdown
Collaborator

This adds two github actions, "Create Release PR" and "release". The first is scheduled to run every 3 weeks to automatically create a release PR that bumps the versions. The "release" action is triggered when the release PR is merged. It will create a draft release with the tars attached.

Assited-by: Claude Code

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds release-commit and next-minor-version make targets to automate the release process. The changes look good, but I have suggestions to make the scripts more robust and safer.

Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread Makefile Outdated
@cgwalters

Copy link
Copy Markdown
Collaborator

Also thanks for working on this, very overdue!

if: github.event_name != 'push'
uses: crazy-max/ghaction-import-gpg@v6
with:
gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make this keypair and add to secrets in this repo right?

And when we do that we'll also want to sign it via web of trust and/or just document the public key explicitly in the repo.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckyrouac Did we ever do anything here? here's my proposal:

My goal here is to be able to reuse exactly the same release workflow (including signing) for bcvk.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/scheduled-release.yml Outdated
This adds two github actions, "Create Release PR" and "release". The
first is scheduled to run every 3 weeks to automatically create a
release PR that bumps the versions. The "release" action is triggered
when the release PR is merged. It will create a draft release with the
tars attached.

Assited-by: Claude Code
Signed-off-by: ckyrouac <ckyrouac@redhat.com>
@cgwalters

Copy link
Copy Markdown
Collaborator

LGTM

@gursewak1997 gursewak1997 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@ckyrouac ckyrouac merged commit 4fc8741 into bootc-dev:main Jul 23, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants