Skip to content

install: Use read_file from composefs-boot#1507

Merged
cgwalters merged 1 commit into
bootc-dev:composefs-backendfrom
cgwalters:composefs-more-cleanups
Aug 13, 2025
Merged

install: Use read_file from composefs-boot#1507
cgwalters merged 1 commit into
bootc-dev:composefs-backendfrom
cgwalters:composefs-more-cleanups

Conversation

@cgwalters

Copy link
Copy Markdown
Collaborator

Just reducing code here.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good simplification. It removes a local implementation of read_file and replaces it with the one from the composefs-boot crate, which helps reduce code duplication. The related changes to imports are also correct. Overall, this is a solid refactoring.

@jeckersb jeckersb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with note that make validate-rust is failing in the composefs-backend branch unrelated to this change:

(cd crates/lib && cargo check --no-default-features)

[... snip ...]

error[E0433]: failed to resolve: could not find `parsers` in the crate root
  --> crates/lib/src/deploy.rs:32:12
   |
32 | use crate::parsers::bls_config::{parse_bls_config, BLSConfig};
   |            ^^^^^^^ could not find `parsers` in the crate root
   |
note: found an item that was configured out
  --> crates/lib/src/lib.rs:41:16
   |
41 | pub(crate) mod parsers;
   |                ^^^^^^^
note: the item is gated behind the `grub` feature
  --> crates/lib/src/lib.rs:40:7
   |
40 | #[cfg(feature = "grub")]
   |       ^^^^^^^^^^^^^^^^

@jeckersb jeckersb mentioned this pull request Aug 13, 2025
22 tasks
@cgwalters

Copy link
Copy Markdown
Collaborator Author

Yeah it'd probably be messy right now to gate it via a feature, but...the grub stuff is super messy itself and it would be nice to cordon it off a bit in the future...

@cgwalters cgwalters merged commit e2b19f9 into bootc-dev:composefs-backend Aug 13, 2025
16 of 20 checks passed
@cgwalters

Copy link
Copy Markdown
Collaborator Author

LGTM, with note that make validate-rust is failing in the composefs-backend branch unrelated to this change:

Fixed in #1512

@cgwalters cgwalters added the area/composefs Issues related to composefs label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/composefs Issues related to composefs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants