Update PR #2155 in repository bootc-dev/bootc to fully fix Fedora 43+ DPS root auto-discovery so the readonly test tmt/tests/booted/readonly/052-test-bli-detection.nu passes.

Context:

• The PR currently adds handling for discoverable-partitions=true in install_to_filesystem() / install_to_existing_root() by omitting root= when explicitly enabled.
• The failing test checks the booted system’s /proc/cmdline and asserts Fedora 43+ has no root=.
• to-disk in crates/lib/src/install/baseline.rs already appears to omit root= when discoverable partitions are enabled.
• There is likely still a path that preserves or reintroduces root= later, especially in install completion / karg reconciliation.

Please investigate and implement the complete fix directly on the PR branch for PR #2155.

Likely areas to inspect:

• crates/lib/src/install.rs
• crates/lib/src/install/baseline.rs
• crates/lib/src/install/completion.rs
• any karg reconciliation / bootconfig mutation paths that might preserve or re-add root= despite discoverable-partitions = true

Requirements:

• Ensure discoverable-partitions=true is honored consistently for to-filesystem, to-existing-root, and any completion/reconciliation path.
• Preserve other necessary root-related kargs where appropriate (for example rootflags= and device-unlock args) while omitting root=.
• Add or update tests to cover the fixed behavior.
• Follow repository instructions in .github/copilot-instructions.md, README.md, CONTRIBUTING.md, and REVIEW.md if relevant.
• Do not include a Signed-off-by trailer unless explicitly requested by a human.
• If generating substantial code, include an Assisted-by: trailer.

Deliverable:

• Push the fix to the existing PR branch and update PR tests: Skip BLI detection test when discoverable-partitions config is absent #2155 with the necessary code and tests.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: https://artifacts.dev.testing-farm.io/95243450-6dd4-418d-bf02-9d81a2f3dd60/work-plan-01-readonlyddc9ptdb/tmt/plans/integration/plan-01-readonly/execute/data/guest/default-0/tmt/tests/tests/test-01-readonly-1/output.txt still looks bad can you review the changes here and the log to see what is missing

Assistant: From the PR, your change does wire discoverable-partitions=true into the to-filesystem / to-existing-root flow by forcing an empty mount_spec, which (per the existing logic) is the signal to omit root=. That part looks conceptually correct.

What’s likely still “missing” (i.e., why the Testing Farm output still “looks bad”) is one of these gaps:

1. The test isn’t actually running with discoverable-partitions=true in the install config (so your new branch never triggers), or the config file isn’t being found/merged in that environment.
2. The boot path being exercised expects more than “omit root=” (e.g., it requires a specific root= style, or it validates the final BLS/bootloader entry content in a way that still fails).
3. The failure is unrelated to root= and the log is pointing at a different issue, but we can’t confirm without the log content.

What I can verify from the code change

In crates/lib/src/install.rs, inside install_to_filesystem() you now do:

• If state.install_config.discoverable_partitions == true:
  • Force RootMountInfo.mount_spec = ""
  • Preserve RootMountInfo.kargs (good: keeps things like rootflags=subvol=...)
• Later:
  • If mount_spec is empty, you now set kargs = root_info.kargs instead of Vec::new(), which is also good (previous behavior dropped those inherited root-related args).

So the “plumbing” seems correct for the intended behavior: no root= but keep rootflags/rd. args*.

Why I can’t directly confirm against the Testing Farm output (yet)

I tried to open your Testing Farm artifact URL, but the web fetch failed with a cache-miss/internal error on my side, so I can’t see the contents of output.txt from here.

What I need from you (minimal) to pinpoint what’s missing

Please paste (or attach) the relevant part of output.txt, specifically:

• the actual failure/error lines (and ~30 lines before them)
• any lines showing the bootc invocation (the exact bootc install ... command)
• any lines showing which install config files were loaded (if bootc logs that)

Quick self-checks you can do immediately in that log

Search in output.txt for these strings and paste the matching sections:

• discoverable-partitions (do you see your new debug/warn?)
  • discoverable-partitions enabled, omitting root= karg
  • discoverable-partitions overrides root-mount-spec; root= will be omitted
• Root mount: (it logs root_info.mount_spec)
• options (often where the final kernel cmdline / BLS options show up)
• root= (does it still appear in the generated entry?)

If none of the discoverable-partitions ... lines appear, then what’s “missing” is very likely **the config isn’t being set/loaded...