Bump Composefs-rs, use buffered UKI readers#2215
Open
Johan-Liebert1 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the UKI (Unified Kernel Image) handling to use buffered, stream-based reading (Read + Seek) instead of loading entire binary files into memory. This change updates several utility functions to use _buffered variants and stream data directly. Additionally, dependencies in Cargo.toml and Cargo.lock are updated. A critical compilation issue was identified in boot.rs where the local parameter name uki shadows the imported uki module, preventing the compiler from resolving module-level functions like uki::get_section_buffered.
Use buffered readers for reading UKI sections instead of loading the entire thing in memory Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
cgwalters
previously approved these changes
May 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Buffered UKI readers fail if the binary being read is not a valid PE binary. To fix tests, create a minimal PE binary Assisted-By: Claude Code (Opus) Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
cgwalters
approved these changes
May 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits