Prepwork for #2200#2240
Merged
Merged
Conversation
While building a sealed UKI image we'd want to remove the original kernel + initramfs from the final image and have only the final UKI present. This was not possible before as `bootc container ukify` expected kernel + initramfs to be present in `usr/lib/modules` of container root We now accept a parameter `kernel_dir` which must be of the format `/path/$kernel_ver` for `bootc container ukify` Fixes: bootc-dev#2185 Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Bootloader set to none is not supported with the composefs backend so we skip tests with this option for composefs backend Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
We were defaulting to unprivileged user "nobody" when pulling an image, but pulling from containers-storage was failing as it requires extra privileges. Default to the current user, usually root, when pulling from containers-storage Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
github-actions
Bot
added
area/install
Open
cgwalters
approved these changes
Jun 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
travier
reviewed
Jun 10, 2026
| #[clap(long)] | ||
| write_dumpfile_to: Option<Utf8PathBuf>, | ||
|
|
||
| /// The directory containing the kernel and initramfs.img |
Contributor
There was a problem hiding this comment.
Suggested change
| /// The directory containing the kernel and initramfs.img | |
| /// The directory containing the kernel and initramfs.img. |
travier
reviewed
Jun 10, 2026
| write_dumpfile_to: Option<Utf8PathBuf>, | ||
|
|
||
| /// The directory containing the kernel and initramfs.img | ||
| /// Must be of the format /parent/$kernel_version |
Contributor
There was a problem hiding this comment.
Maybe?
Suggested change
| /// Must be of the format /parent/$kernel_version | |
| /// Must be of the format `/parent/$kernel_version`. |
travier
reviewed
Jun 10, 2026
|
|
||
| setenforce 0 | ||
|
|
||
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ukify: Allow passing path to kernel and initramfs
While building a sealed UKI image we'd want to remove the original
kernel + initramfs from the final image and have only the final UKI
present. This was not possible before as
bootc container ukifyexpected kernel + initramfs to be present in
usr/lib/modulesofcontainer root
We now accept a parameter
kernel_dirwhich must be of the format/path/$kernel_verforbootc container ukifyFixes: #2185
test/tmt: Don't run bootloader-none test for composefs
Bootloader set to none is not supported with the composefs backend so we
skip tests with this option for composefs backend
image-proxy: Use privileged user when pull from containers storage
We were defaulting to unprivileged user "nobody" when pulling an image,
but pulling from containers-storage was failing as it requires extra
privileges. Default to the current user, usually root, when pulling from
containers-storage