devenv: Add skopeo and fsverity-utils for bootc/composefs testing#115
devenv: Add skopeo and fsverity-utils for bootc/composefs testing#115jeckersb merged 2 commits intobootc-dev:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the development environment by incorporating essential tools required for bootc and composefs testing. It ensures that skopeo is available across all environments and specifically addresses the inclusion of fsverity-utils for both Debian and CentOS Stream 10, facilitating comprehensive testing of container images and filesystem integrity features. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds skopeo and fsverity-utils as dependencies for testing purposes. However, the installation of fsverity-utils on CentOS Stream 10 directly from Koji without explicit GPG signature or checksum verification introduces a potential supply chain risk. While the source is trusted, this practice bypasses standard security mechanisms. A specific suggestion has been provided for devenv/Containerfile.c10s to address this and improve maintainability.
These are dependencies needed for bootc and composefs testing: - skopeo: container image inspection/copy tool (same package name on both Debian and CentOS, added to packages-common.txt) - fsverity-utils: filesystem verity utilities for composefs. On Debian the binary package is 'fsverity' (added to packages-debian.txt). On CentOS Stream 10 the package is not yet in the base repos, so we install it directly from Koji build 2949299. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
8999b20 to
05479bb
Compare
These are dependencies needed for bootc and composefs testing:
Assisted-by: OpenCode (Claude claude-opus-4-6)