devenv: Explicitly install ca-certificates before curl#142
devenv: Explicitly install ca-certificates before curl#142cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
The Debian sid base image may not include ca-certificates, and curl only Recommends (not Depends on) it. This causes curl to fail with SSL trust anchor errors when fetching the GitHub CLI keyring. Assisted-by: Claude Code (Opus 4.6) Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in the Debian sid base image where Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This change adds the ca-certificates package to the initial package installation list in the devenv/Containerfile.debian. This is intended to prevent SSL errors when curl is used to fetch resources over HTTPS. The modification is confined to a single line and is a direct implementation of the described fix. After reviewing the change, I have not identified any issues or necessary improvements within the scope of the modification.
|
From AI's help for the package install failure. |
Yeah, it probably makes sense to back off using Debian sid by default and go to just cherry picking a few things. In fact what would likely help a lot here is to use the same code for bootc-ubuntu-setup on top of ubuntu-24.04. |
Can I replace Containerfile.debian based on ubuntu:24.04? The DevContainer will be ubuntu one. |
|
I think in order to avoid breaking things let's add a new one, then roll it out by default. That said we already have the c10s based one, we could also just use that by default. One thing that'd be nice if is devcontainers supported "alternative images" nicely as we're doing here so folks can choose. |
The Debian sid base image may not include ca-certificates, and curl only Recommends (not Depends on) it. This causes curl to fail with SSL trust anchor errors when fetching the GitHub CLI keyring.
Assisted-by: Claude Code (Opus 4.6)