Skip to content

Two devenv patches#93

Merged
gursewak1997 merged 2 commits intobootc-dev:mainfrom
cgwalters:add-kani
Jan 27, 2026
Merged

Two devenv patches#93
gursewak1997 merged 2 commits intobootc-dev:mainfrom
cgwalters:add-kani

Conversation

@cgwalters
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the development environment setup for both c10s and Debian-based container images. By extracting the installation logic for various tools (like goose, bcvk, and scorecard) and Rust into separate, reusable shell scripts, the Containerfiles become much cleaner and easier to maintain. A key addition is the integration of the Kani formal verification tool, providing enhanced capabilities for static analysis of Rust code within the development environment.

Highlights

  • Refactored Containerfile Logic: Consolidated complex tool and Rust installation steps from devenv/Containerfile.c10s and devenv/Containerfile.debian into dedicated, reusable shell scripts (fetch-tools.sh, install-rust.sh, install-kani.sh).
  • Kani Formal Verification Integration: Integrated the Kani formal verification tool into the development environment, providing advanced static analysis capabilities for Rust projects.
  • Improved Dockerignore: Updated the .dockerignore file to properly exclude the newly introduced installation scripts, ensuring cleaner and more efficient Docker builds.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the devenv Containerfiles by extracting shell script logic into separate, reusable files, which improves maintainability and readability. It also adds support for the Kani formal verification tool. My review includes a few suggestions to improve robustness and consistency, such as fixing a potential bug in fetch-tools.sh and aligning package manager cache cleaning practices across Docker stages.

Comment thread devenv/fetch-tools.sh
Comment thread devenv/Containerfile.c10s Outdated
Comment thread devenv/Containerfile.debian Outdated
Comment thread devenv/fetch-tools.sh Outdated
Goose is not currently needed in the devenv image.

Assisted-by: OpenCode (Claude Sonnet 4)
Signed-off-by: Colin Walters <walters@verbum.org>
Add Kani formal verification tool - a bounded model checker for Rust
that can verify safety properties and absence of undefined behavior.
Kani requires rustup because it bundles a specific nightly toolchain.

Also deduplicate the installation logic between c10s and debian
Containerfiles by extracting into shared shell scripts:

- fetch-tools.sh: Downloads bcvk and scorecard binaries
- install-rust.sh: Installs rustup/cargo system-wide to /usr/local
- install-kani.sh: Installs kani formal verification tool

Key changes:
- Add rustup symlink at $CARGO_HOME/bin/rustup (required for rustup's
  self-update check which looks for itself there)
- Add new 'kani' build stage that compiles kani-verifier and runs setup
- Set KANI_HOME=/usr/local/kani for system-wide installation
- Copy kani bundle (compiler, libraries, CBMC) to final image

The kani version is renovate-managed via the kaniversion ARG.

Assisted-by: OpenCode (Claude Sonnet 4)
Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Copy Markdown
Contributor

@gursewak1997 gursewak1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gursewak1997 gursewak1997 merged commit 63ddb5c into bootc-dev:main Jan 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants