Merge pull request #107 from bootgs/fix/route-inheritance-bug

MaksymStoianov · web-flow · commit 940774ae26fe · 2026-04-15T17:57:10.000+02:00
Fix/route inheritance bug
diff --git a/README.md b/README.md
@@ -236,8 +236,8 @@ Use this when building Sidebars, Modals, or Add-ons.
 **Example (Client-side JS):**
 
 ```javascript
-const path = '/api/users/123';
-const method = 'GET';
+const path = "/api/users/123";
+const method = "GET";
 const headers = JSON.stringify({
   "X-Request-Source": "internal"
 });
@@ -259,14 +259,14 @@ const event = {
 };
 
 google.script.run
-  .withSuccessHandler(response => {
+  .withSuccessHandler((response) => {
     // Parse the optimized string response
-    const result = typeof response === 'string' ? JSON.parse(response) : response;
-    
+    const result = typeof response === "string" ? JSON.parse(response) : response;
+
     console.log("Status:", result.status);
     console.log("Data:", result.body);
   })
-  .doGet(event); 
+  .doGet(event);
 ```
 
 #### 2. External Usage (Web App URL)
@@ -281,7 +281,9 @@ Use this when accessing the script via a direct link, a webhook, or a third-part
 The framework automatically handles your controller's return value based on whether the `@ResponseBody` decorator is used (note that `@RestController` applies this by default):
 
 #### A. Default Wrapper (No `@ResponseBody`)
+
 If the controller method is not marked with `@ResponseBody`, the framework returns a full HTTP-like payload:
+
 ```json
 {
   "status": 200,
@@ -293,6 +295,7 @@ If the controller method is not marked with `@ResponseBody`, the framework retur
 ```
 
 #### B. Direct Context (`@ResponseBody`)
+
 If the method is marked with `@ResponseBody`, the framework bypasses the payload wrapper and returns only the data directly.
 
 > [!TIP]
diff --git a/config/eslint/overrides-tests.ts b/config/eslint/overrides-tests.ts
@@ -16,7 +16,7 @@ const config: Linter.Config = {
      * Disallows unused variables.
      * @see {@link https://typescript-eslint.io/rules/no-unused-vars/ no-unused-vars}
      */
-    "@typescript-eslint/no-unused-vars": "error"
+    "@typescript-eslint/no-unused-vars": "off"
   }
 };
 
diff --git a/src/service/EventDispatcher.ts b/src/service/EventDispatcher.ts
@@ -37,46 +37,54 @@ export class EventDispatcher {
     const promises: Promise<void>[] = [];
 
     for (const controller of this.controllers.keys()) {
-      const prototype: Record<string, unknown> = (controller as any).prototype;
+      const processedMethods: Set<string> = new Set<string>();
 
-      const propertyNames: string[] = Object.getOwnPropertyNames(prototype);
+      let prototype: object = (controller as any).prototype;
 
-      for (const propertyName of propertyNames) {
-        if (propertyName === "constructor") {
-          continue;
-        }
+      while (prototype && prototype !== Object.prototype) {
+        const propertyNames: string[] = Object.getOwnPropertyNames(prototype);
 
-        const methodHandler: unknown = prototype[propertyName];
+        for (const propertyName of propertyNames) {
+          if (propertyName === "constructor" || processedMethods.has(propertyName)) {
+            continue;
+          }
 
-        const eventMetadata: AppsScriptEventType | undefined = Reflect.getMetadata(
-          APPSSCRIPT_EVENT_METADATA,
-          methodHandler as object
-        );
+          processedMethods.add(propertyName);
 
-        const options: Record<string, unknown> | undefined = Reflect.getMetadata(
-          APPSSCRIPT_OPTIONS_METADATA,
-          methodHandler as object
-        );
+          const methodHandler: unknown = (prototype as any)[propertyName];
 
-        if (eventMetadata === eventType && this.checkFilters(eventType, event, options)) {
-          const instance: unknown = this.resolver.resolve(controller);
+          const eventMetadata: AppsScriptEventType | undefined = Reflect.getMetadata(
+            APPSSCRIPT_EVENT_METADATA,
+            methodHandler as object
+          );
 
-          if (!isRecord(instance)) {
-            continue;
-          }
+          const options: Record<string, unknown> | undefined = Reflect.getMetadata(
+            APPSSCRIPT_OPTIONS_METADATA,
+            methodHandler as object
+          );
+
+          if (eventMetadata === eventType && this.checkFilters(eventType, event, options)) {
+            const instance: unknown = this.resolver.resolve(controller);
 
-          const args: unknown[] = this.buildMethodParams(instance, propertyName, event);
+            if (!isRecord(instance)) {
+              continue;
+            }
+
+            const args: unknown[] = this.buildMethodParams(instance, propertyName, event);
 
-          const handler: unknown = instance[propertyName];
+            const handler: unknown = instance[propertyName];
 
-          if (isFunctionLike(handler)) {
-            const result: unknown = Reflect.apply(handler, instance, args);
+            if (isFunctionLike(handler)) {
+              const result: unknown = Reflect.apply(handler, instance, args);
 
-            if (result instanceof Promise) {
-              promises.push(result);
+              if (result instanceof Promise) {
+                promises.push(result);
+              }
             }
           }
         }
+
+        prototype = Object.getPrototypeOf(prototype);
       }
     }
 
diff --git a/src/service/Router.ts b/src/service/Router.ts
@@ -382,27 +382,38 @@ export class Router {
       return null;
     }
 
-    const prototype: any = Object.getPrototypeOf(instance);
+    let prototype: any = Object.getPrototypeOf(instance);
+    const visitedMethods: Set<string> = new Set<string>();
 
-    const propertyNames: string[] = Object.getOwnPropertyNames(prototype);
+    while (prototype && prototype !== Object.prototype) {
+      const propertyNames: string[] = Object.getOwnPropertyNames(prototype);
 
-    for (const propertyName of propertyNames) {
-      const method: any = instance[propertyName];
+      for (const propertyName of propertyNames) {
+        if (propertyName === "constructor" || visitedMethods.has(propertyName)) {
+          continue;
+        }
 
-      if (!isFunctionLike(method)) continue;
+        visitedMethods.add(propertyName);
 
-      const exceptions: Newable<Error>[] | undefined = Reflect.getMetadata(
-        EXCEPTION_HANDLER_METADATA,
-        method
-      );
+        const method: any = instance[propertyName];
 
-      if (exceptions && Array.isArray(exceptions)) {
-        for (const exceptionClass of exceptions) {
-          if (err instanceof exceptionClass) {
-            return propertyName;
+        if (!isFunctionLike(method)) continue;
+
+        const exceptions: Newable<Error>[] | undefined = Reflect.getMetadata(
+          EXCEPTION_HANDLER_METADATA,
+          method
+        );
+
+        if (exceptions && Array.isArray(exceptions)) {
+          for (const exceptionClass of exceptions) {
+            if (err instanceof exceptionClass) {
+              return propertyName;
+            }
           }
         }
       }
+
+      prototype = Object.getPrototypeOf(prototype);
     }
 
     return null;
diff --git a/src/service/RouterExplorer.ts b/src/service/RouterExplorer.ts
@@ -37,47 +37,54 @@ export class RouterExplorer {
 
       const basePath: string = (controllerOptions.basePath as string) || "/";
 
-      const prototype: Record<string, unknown> = (controller as any).prototype;
+      let prototype: object = (controller as any).prototype;
+      const visitedMethods: Set<string> = new Set<string>();
 
-      const propertyNames: string[] = Object.getOwnPropertyNames(prototype);
+      while (prototype && prototype !== Object.prototype) {
+        const propertyNames: string[] = Object.getOwnPropertyNames(prototype);
 
-      for (const propertyName of propertyNames) {
-        if (propertyName === "constructor") {
-          continue;
-        }
+        for (const propertyName of propertyNames) {
+          if (propertyName === "constructor" || visitedMethods.has(propertyName)) {
+            continue;
+          }
 
-        const methodHandler: unknown = prototype[propertyName];
-
-        const routePath: string | undefined = Reflect.getMetadata(
-          PATH_METADATA,
-          methodHandler as object
-        );
-
-        const requestMethods: RequestMethod | RequestMethod[] | undefined = Reflect.getMetadata(
-          METHOD_METADATA,
-          methodHandler as object
-        );
-
-        const produce: ContentMimeType | undefined = Reflect.getMetadata(
-          PRODUCE_METADATA,
-          methodHandler as object
-        );
-
-        if (routePath && requestMethods) {
-          const methods: RequestMethod[] = Array.isArray(requestMethods)
-            ? requestMethods
-            : [requestMethods];
-
-          for (const method of methods) {
-            routes.push({
-              controller,
-              handler: propertyName,
-              method,
-              path: decodeURI(normalize(`/${basePath}/${routePath}`)),
-              produce
-            });
+          visitedMethods.add(propertyName);
+
+          const methodHandler: unknown = (prototype as any)[propertyName];
+
+          const routePath: string | undefined = Reflect.getMetadata(
+            PATH_METADATA,
+            methodHandler as object
+          );
+
+          const requestMethods: RequestMethod | RequestMethod[] | undefined = Reflect.getMetadata(
+            METHOD_METADATA,
+            methodHandler as object
+          );
+
+          const produce: ContentMimeType | undefined = Reflect.getMetadata(
+            PRODUCE_METADATA,
+            methodHandler as object
+          );
+
+          if (routePath && requestMethods) {
+            const methods: RequestMethod[] = Array.isArray(requestMethods)
+              ? requestMethods
+              : [requestMethods];
+
+            for (const method of methods) {
+              routes.push({
+                controller,
+                handler: propertyName,
+                method,
+                path: decodeURI(normalize(`/${basePath}/${routePath}`)),
+                produce
+              });
+            }
           }
         }
+
+        prototype = Object.getPrototypeOf(prototype);
       }
     }
 
diff --git a/test/InheritanceShadowing.test.ts b/test/InheritanceShadowing.test.ts
diff --git a/test/ValidationDecorators.test.ts b/test/ValidationDecorators.test.ts

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ const config: Linter.Config = {`
`16`	`16`	`* Disallows unused variables.`
`17`	`17`	`* @see {@link https://typescript-eslint.io/rules/no-unused-vars/ no-unused-vars}`
`18`	`18`	`*/`
`19`		`- "@typescript-eslint/no-unused-vars": "error"`
	`19`	`+ "@typescript-eslint/no-unused-vars": "off"`
`20`	`20`	`}`
`21`	`21`	`};`
`22`	`22`