Commit 0d44fd1
committed
feat(scripts): M5a — claude[bot] minor + suggestion on PR #924
claude[bot] review on 834b172 — all 4 gemini fixes confirmed
correct. Two non-blocking notes addressed inline:
* Minor — line 75-78 comment overstated scope. The guard
runs unconditionally, not just under --no-rebuild.
Rewrote the comment to reflect the actual semantics
(catches both the --no-rebuild case AND a fresh-build
environment where a helper somehow produced a
non-executable).
* Suggestion — cross-PR dependency machine-readable guard.
Added a pre-flight check before 'go build ./cmd/elastickv-list-routes'
that surfaces a clear error if cmd/elastickv-list-routes/
doesn't exist in the current tree (i.e. PR #925 hasn't
been merged yet). Without this guard, anyone trying to
run the script from PR #924 alone gets an opaque
'package not found' error from go build with no
remediation hint.
Verification: bash -n scripts/run-jepsen-m5-local.sh -> OK.1 parent 834b172 commit 0d44fd1
1 file changed
Lines changed: 17 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
54 | 64 | | |
55 | 65 | | |
56 | 66 | | |
| |||
72 | 82 | | |
73 | 83 | | |
74 | 84 | | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
79 | 92 | | |
80 | 93 | | |
81 | 94 | | |
| |||
0 commit comments