Commit 1133178
committed
docs(admin): fix audit log shapes and split login 401 vs 403
Two findings from the latest claude review on #674:
1. **Audit log shapes (Bug A)**: the previous example claimed
`admin_audit ... operation=delete_table table=orders` was a
leader-direct sample, but `DynamoHandler.handleDelete`
(dynamo_handler.go:379-396) does not emit any handler-level
admin_audit — that shape only appears via `ForwardServer` on
the forwarded path. It also omitted the `Audit` middleware line
(middleware.go:206-232) which wraps every non-GET admin request
with method= / path= / status= / remote= / duration=. An
operator building a parser against the doc would have missed
half of the actual lines.
Rewrote the section as three explicit shapes — Audit middleware
(always), S3Handler op line (only emits from s3_handler.go:299
/333/355), ForwardServer op line (covers both Dynamo and S3
forwarded paths). Removed the misleading `delete_table`
leader-direct sample and replaced the Dynamo examples with
forwarded-only ones, which is where they actually originate.
Added a one-sentence note that a single request typically
produces two lines (op-specific + middleware) so log parsers
know to treat the key as a union.
2. **Login 401 vs 403 (Codex P2)**: the troubleshooting entry said
"both produce 401" but auth_handler.go:336-345 returns 403
forbidden when the credentials match but the access key is not
in `-adminFullAccessKeys` / `-adminReadOnlyAccessKeys`. Split
into two entries: 401 invalid_credentials (bad access_key or
secret) and 403 forbidden (valid SigV4 creds, but no admin
role assignment), with the remediation specific to each case.
No functional changes. Doc-only.1 parent 8c2fa3e commit 1133178
1 file changed
Lines changed: 50 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
177 | | - | |
178 | | - | |
179 | | - | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
180 | 190 | | |
181 | | - | |
182 | | - | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
183 | 199 | | |
184 | 200 | | |
185 | 201 | | |
186 | | - | |
| 202 | + | |
| 203 | + | |
187 | 204 | | |
188 | 205 | | |
189 | | - | |
190 | | - | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
191 | 210 | | |
192 | 211 | | |
| 212 | + | |
| 213 | + | |
193 | 214 | | |
194 | 215 | | |
195 | 216 | | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
200 | 220 | | |
201 | | - | |
202 | | - | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
203 | 224 | | |
204 | 225 | | |
205 | 226 | | |
| |||
220 | 241 | | |
221 | 242 | | |
222 | 243 | | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
228 | 259 | | |
229 | 260 | | |
230 | 261 | | |
| |||
0 commit comments