style(sqs): strip PR/round attributions from .go comments per CLAUDE.md (PR #664 round 14)

Claude low on round 13.1: ~25+ comments across the SQS Go files reference review attributions ('Codex P1 on PR #679', 'CodeRabbit Major on PR #664 round 11', etc.). CLAUDE.md is explicit: 'Don't reference the current task, fix, or callers ... since those belong in the PR description and rot as the codebase evolves.'

Sweep across:
- adapter/sqs_throttle.go
- adapter/sqs_catalog.go
- adapter/sqs_partitioning.go
- adapter/sqs_messages.go
- adapter/sqs_throttle_test.go
- adapter/sqs_partitioning_test.go
- adapter/sqs_throttle_integration_test.go
- adapter/sqs_partitioning_integration_test.go
- adapter/sqs_catalog_test.go
- adapter/sqs_query_protocol.go
- adapter/sqs_query_protocol_test.go

Each comment now retains the substantive WHY (why the design choice was made) and drops the parenthetical attribution to a specific reviewer / PR number / round. Design docs (.md files) are exempt — those are archival records where review attribution is acceptable practice.

go test -race ./adapter/... pass; golangci-lint ./... clean. No behaviour change.

Author: bootjp

adapter/sqs_catalog.go

@@ -86,7 +86,7 @@ type sqsQueueMeta struct {
 	// This is the throttle-bucket-key field — keying by Incarnation
 	// instead of Generation prevents PurgeQueue from resetting the
 	// in-memory token bucket while still isolating delete+recreate
-	// incarnations from each other (Codex P2 on PR #664 round 9).
+	// incarnations from each other.
 	Incarnation               uint64            `json:"incarnation,omitempty"`
 	CreatedAtHLC              uint64            `json:"created_at_hlc,omitempty"`
 	IsFIFO                    bool              `json:"is_fifo,omitempty"`
@@ -674,9 +674,7 @@ func validateThrottleConfig(meta *sqsQueueMeta) error {
 	// `ThrottleDefaultCapacity=5, ThrottleDefaultRefillPerSecond=1`
 	// would be accepted but make every full SendMessageBatch /
 	// DeleteMessageBatch (charge=10) permanently unserviceable —
-	// the bucket can never accumulate the 10 tokens. Codex P1 on
-	// PR #679 round 5 caught the gap; the design doc note in §3.2
-	// claiming Default* is exempt was wrong about the fall-through.
+	// the bucket can never accumulate the 10 tokens.
 	if err := validateThrottlePair("ThrottleDefault", t.DefaultCapacity, t.DefaultRefillPerSecond, true); err != nil {
 		return err
 	}
@@ -805,9 +803,8 @@ func throttleConfigEqual(a, b *sqsQueueThrottle) bool {
 // without PartitionCount is stored as 0 while a queue created with
 // explicit PartitionCount=1 is stored as 1, so strict equality would
 // have CreateQueue reject the second call as "different attributes"
-// even though the queues are semantically identical (Codex P2 on
-// PR #679 round 6.1). normalisePartitionCount maps both to 1 for the
-// idempotency check.
+// even though the queues are semantically identical.
+// normalisePartitionCount maps both to 1 for the idempotency check.
 func htfifoAttributesEqual(a, b *sqsQueueMeta) bool {
 	return normalisePartitionCount(a.PartitionCount) == normalisePartitionCount(b.PartitionCount) &&
 		a.FifoThroughputLimit == b.FifoThroughputLimit &&
@@ -1006,8 +1003,8 @@ func (s *SQSServer) tryCreateQueueOnce(ctx context.Context, requested *sqsQueueM
 	if _, err := s.coordinator.Dispatch(ctx, req); err != nil {
 		return false, errors.WithStack(err)
 	}
-	// Drop any throttle bucket that survived a delete-then-create race
-	// (Codex P2 on PR #679 round 5). DeleteQueue invalidates after its
+	// Drop any throttle bucket that survived a delete-then-create
+	// race. DeleteQueue invalidates after its
 	// commit, but a sendMessage holding pre-delete meta can recreate
 	// a bucket between that invalidate and this CreateQueue commit;
 	// invalidating again here on a genuine create (not the idempotent
@@ -1447,12 +1444,11 @@ func (s *SQSServer) setQueueAttributes(w http.ResponseWriter, r *http.Request) {
 	// reset the bucket on every unrelated SetQueueAttributes (e.g.
 	// VisibilityTimeout-only update), giving any caller a way to
 	// silently restore a noisy tenant's burst capacity by writing a
-	// no-op SetQueueAttributes (Codex P1 on PR #679, refined on PR
-	// #664 round 9). Gating on key-presence alone is not enough either
-	// — a same-value Throttle* write would still pass the presence
-	// check and invalidate, so a caller could repeat their own current
-	// throttle config to bump the bucket back to full capacity (Codex
-	// P1 on PR #664 round 9). trySetQueueAttributesOnce therefore
+	// no-op SetQueueAttributes. Gating on key-presence alone is not
+	// enough either — a same-value Throttle* write would still pass
+	// the presence check and invalidate, so a caller could repeat
+	// their own current throttle config to bump the bucket back to
+	// full capacity. trySetQueueAttributesOnce therefore
 	// compares the old and new throttle configs under the same Raft
 	// read snapshot used for the commit and reports whether the values
 	// actually moved. The bucket reconciliation in loadOrInit also
@@ -1492,8 +1488,7 @@ func (s *SQSServer) setQueueAttributesWithRetry(ctx context.Context, queueName s
 // sqsAPIError the caller forwards to writeSQSErrorFromErr.
 //
 // preApply snapshot allocation is gated on htfifoAttributesPresent
-// so the common "mutable-only update" path stays alloc-free per the
-// Gemini medium feedback on PR #681.
+// so the common "mutable-only update" path stays alloc-free.
 func applyAndValidateSetAttributes(meta *sqsQueueMeta, attrs map[string]string) error {
 	var preApply *sqsQueueMeta
 	if htfifoAttributesPresent(attrs) {
@@ -1528,7 +1523,7 @@ func applyAndValidateSetAttributes(meta *sqsQueueMeta, attrs map[string]string)
 // the post-apply meta's Throttle config differs from the pre-apply
 // snapshot — the caller uses it to gate the cache invalidation so
 // that a no-op same-value SetQueueAttributes does not reset the
-// bucket to full capacity (Codex P1 on PR #664 round 9).
+// bucket to full capacity.
 func (s *SQSServer) trySetQueueAttributesOnce(ctx context.Context, queueName string, attrs map[string]string) (bool, bool, error) {
 	readTS := s.nextTxnReadTS(ctx)
 	meta, exists, err := s.loadQueueMetaAt(ctx, queueName, readTS)

adapter/sqs_catalog_test.go

@@ -143,7 +143,7 @@ func TestSQSServer_CatalogCreateIsIdempotent(t *testing.T) {
 	// notice the diff and the call must reject as QueueNameExists.
 	// Without this case a bug in throttleConfigEqual (e.g. always
 	// returning true) would slip past the existing VisibilityTimeout-
-	// only test (Claude review on PR #679 round 2).
+	// only test.
 	withThrottle := map[string]any{
 		"QueueName": "idempotent",
 		"Attributes": map[string]string{

adapter/sqs_messages.go

@@ -297,7 +297,7 @@ type sqsChangeVisibilityInput struct {
 // prepareSendMessage decodes the SendMessage payload and resolves
 // the queue name. Throttle charging happens after the meta load in
 // validateSend so we don't pay an extra meta read just to discover
-// throttling is off (Gemini high on PR #679).
+// throttling is off.
 func (s *SQSServer) prepareSendMessage(w http.ResponseWriter, r *http.Request) (sqsSendMessageInput, string, bool) {
 	var in sqsSendMessageInput
 	if err := decodeSQSJSONInput(r, &in); err != nil {
@@ -565,9 +565,9 @@ func (s *SQSServer) receiveMessage(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	// Throttle check uses the loaded meta's throttle config so we
-	// don't pay an extra meta read just to discover throttling is off
-	// (Gemini high on PR #679). Sits AFTER the QueueDoesNotExist
-	// branch — a missing queue should not consume a Recv token.
+	// don't pay an extra meta read just to discover throttling is
+	// off. Sits AFTER the QueueDoesNotExist branch — a missing queue
+	// should not consume a Recv token.
 	if !s.chargeQueueWithThrottle(w, queueName, bucketActionReceive, 1, meta.Throttle, meta.Incarnation) {
 		return
 	}

adapter/sqs_partitioning.go

@@ -80,16 +80,16 @@ func partitionFor(meta *sqsQueueMeta, messageGroupID string) uint32 {
 		return 0
 	}
 	// Inlined FNV-1a 32-bit over the string to avoid the []byte
-	// allocation hash/fnv.New32a + h.Write would force (Gemini medium
-	// on PR #681). MessageGroupId is capped at 128 chars by validation,
+	// allocation hash/fnv.New32a + h.Write would force.
+	// MessageGroupId is capped at 128 chars by validation,
 	// so this loop bounds at 128 iterations of integer arithmetic per
 	// SendMessage — measurably faster than the hash.Hash interface
 	// path on the routing hot path. The 32-bit variant keeps the
 	// computation in uint32 throughout, sidestepping the uint64 →
-	// uint32 narrowing that the 64-bit variant would have required for
-	// the partition mask AND (CodeRabbit nit on PR #664 round 7 — the
-	// previous implementation needed `//nolint:gosec G115` to silence
-	// a false positive on the safe-by-construction narrow). PartitionCount
+	// uint32 narrowing that the 64-bit variant would have required
+	// for the partition mask AND (which gosec G115 would otherwise
+	// flag and force a //nolint suppression on a safe-by-construction
+	// narrow). PartitionCount
 	// ≤ htfifoMaxPartitions = 32 so log2(PartitionCount) ≤ 5; only the
 	// low 5 bits of the hash ever survive the mask, and 32-bit FNV-1a
 	// is more than enough entropy to spread MessageGroupId values
@@ -146,15 +146,14 @@ func validatePartitionConfig(meta *sqsQueueMeta) error {
 		}
 	}
 	if meta.PartitionCount > 1 && meta.DeduplicationScope == htfifoDedupeScopeQueue {
-		// sqsErrValidation is "InvalidParameterValue" (Gemini medium
-		// on PR #681 — uses the existing constant rather than a
-		// duplicate-value alias).
+		// sqsErrValidation is "InvalidParameterValue"; uses the
+		// existing constant rather than a duplicate-value alias.
 		return newSQSAPIError(http.StatusBadRequest, sqsErrValidation,
 			"queue-scoped deduplication is incompatible with multi-partition FIFO because the dedup key cannot be globally unique across partitions without a cross-partition OCC transaction")
 	}
 	// FifoThroughputLimit=perMessageGroupId requires an explicit
-	// PartitionCount > 1 (CodeRabbit Major on PR #664 round 11). §7.2
-	// of the design used to suggest "infer a sensible default, e.g.
+	// PartitionCount > 1. §7.2 of the design used to suggest
+	// "infer a sensible default, e.g.
 	// 8" for HT-FIFO callers that omit PartitionCount, but a hidden
 	// default makes CreateQueue idempotency depend on deployment
 	// state — the same wire payload could resolve to a 4-partition
@@ -173,8 +172,8 @@ func validatePartitionConfig(meta *sqsQueueMeta) error {
 // validatePartitionShape enforces the structural rules on
 // PartitionCount: power-of-two and within the per-queue cap. Split
 // out of validatePartitionConfig to keep that function under the
-// cyclop ceiling once the round-12 perMessageGroupId-requires-explicit
-// rule landed.
+// cyclop ceiling once the perMessageGroupId-requires-explicit rule
+// landed.
 func validatePartitionShape(meta *sqsQueueMeta) error {
 	if meta.PartitionCount == 0 {
 		return nil
@@ -194,8 +193,8 @@ func validatePartitionShape(meta *sqsQueueMeta) error {
 // the HT-FIFO attributes. PartitionCount > 1 only makes sense on FIFO
 // queues (HT-FIFO is by definition a FIFO feature). Without this guard
 // a Standard queue with PartitionCount=2 would slip past the validator
-// once PR 5 lifts the dormancy gate (Claude review on PR #681 round 2
-// caught this). PartitionCount=0 and 1 are accepted because both mean
+// once PR 5 lifts the dormancy gate. PartitionCount=0 and 1 are
+// accepted because both mean
 // "single-partition layout" which is valid on Standard queues.
 func validateStandardQueueRejectsHTFIFO(meta *sqsQueueMeta) error {
 	if meta.PartitionCount > 1 {
@@ -248,7 +247,7 @@ func validatePartitionDormancyGate(meta *sqsQueueMeta) error {
 // queue stored with 0, or 0 on a queue stored with 1) is treated as
 // the no-op it semantically is — strict equality would reject with
 // "PartitionCount is immutable" even though the partition layout
-// hasn't changed (Claude Low on PR #679 round 6.2).
+// hasn't changed.
 func validatePartitionImmutability(current, requested *sqsQueueMeta) error {
 	if current == nil || requested == nil {
 		return nil

adapter/sqs_partitioning_integration_test.go

@@ -155,10 +155,10 @@ func TestSQSServer_HTFIFO_ImmutabilitySetQueueAttributesRejects(t *testing.T) {
 
 	url := mustCreateFIFOWithThroughputLimit(t, node, "htfifo-immutable.fifo", htfifoThroughputPerQueue)
 
-	// Try to flip FifoThroughputLimit. Must reject (immutability +
-	// the round-12 rule that perMessageGroupId requires
-	// PartitionCount > 1 both fire on this attempt; either one
-	// rejecting is the correct outcome from the wire).
+	// Try to flip FifoThroughputLimit. Must reject — both the
+	// immutability rule and the rule that perMessageGroupId requires
+	// PartitionCount > 1 fire on this attempt; either one rejecting
+	// is the correct outcome from the wire.
 	status, out := callSQS(t, node, sqsSetQueueAttributesTarget, map[string]any{
 		"QueueUrl": url,
 		"Attributes": map[string]string{

adapter/sqs_partitioning_test.go

@@ -164,10 +164,10 @@ func TestValidatePartitionConfig_RejectsAboveMax(t *testing.T) {
 // reject with InvalidAttributeValue. Setting them silently on a
 // Standard queue would advertise unsupported behaviour.
 //
-// PartitionCount > 1 is also FIFO-only (Claude review on PR #681
-// round 2 caught the gap) — without the guard a Standard queue
-// with PartitionCount=2 would slip past the validator after PR 5
-// lifts the dormancy gate. PartitionCount 0/1 are still accepted
+// PartitionCount > 1 is also FIFO-only — without the guard a
+// Standard queue with PartitionCount=2 would slip past the validator
+// after PR 5 lifts the dormancy gate. PartitionCount 0/1 are still
+// accepted
 // on Standard queues because both mean "single-partition layout".
 func TestValidatePartitionConfig_StandardQueueRejectsHTFIFOAttrs(t *testing.T) {
 	t.Parallel()
@@ -210,7 +210,7 @@ func TestValidatePartitionConfig_RejectsQueueScopedDedupOnPartitioned(t *testing
 }
 
 // TestValidatePartitionConfig_PerMessageGroupIDRequiresExplicitPartitionCount
-// pins the CodeRabbit Major fix on PR #664 round 11: an HT-FIFO
+// pins the no-implicit-default rule: an HT-FIFO
 // CreateQueue request that sets FifoThroughputLimit=perMessageGroupId
 // without an explicit PartitionCount > 1 must be rejected. Earlier
 // drafts of §7.2 proposed inferring a server-side default (e.g. 8),
@@ -310,7 +310,7 @@ func TestValidatePartitionImmutability_RejectsAnyChange(t *testing.T) {
 }
 
 // TestValidatePartitionImmutability_PartitionCountZeroAndOneEquivalent
-// pins the Claude Low fix on PR #679 round 6.2 / 6.3. The on-disk
+// pins the 0/1 normalisation: the on-disk
 // PartitionCount=0 ("unset") is canonical-equivalent to an explicit
 // PartitionCount=1 ("single partition"), so a SetQueueAttributes
 // that reaffirms the default ought to be a no-op rather than a hard
@@ -362,8 +362,8 @@ func TestHTFIFOAttributesPresent(t *testing.T) {
 }
 
 // TestHTFIFOAttributesEqual_PartitionCountZeroAndOneEquivalent pins
-// the Codex P2 fix on PR #679 round 6.1: validatePartitionConfig
-// documents PartitionCount=0 (unset) and =1 (explicit single
+// the idempotency normalisation: validatePartitionConfig documents
+// PartitionCount=0 (unset) and =1 (explicit single
 // partition) as semantically identical legacy/single-partition
 // routing, so CreateQueue idempotency must treat them as equal —
 // otherwise a queue created without PartitionCount (stored as 0) is

adapter/sqs_query_protocol.go

@@ -147,9 +147,9 @@ func readQueryForm(r *http.Request) (url.Values, error) {
 		return nil, newSQSAPIError(http.StatusBadRequest, sqsErrMalformedRequest, "missing request URL")
 	}
 	// r.URL.Query() returns a fresh map on each call so we can adopt
-	// it directly as the base instead of copying entries one-by-one
-	// (Gemini high-priority on PR #662). On GET we are done; on POST
-	// the body's form values are merged into the same map.
+	// it directly as the base instead of copying entries one-by-one.
+	// On GET we are done; on POST the body's form values are merged
+	// into the same map.
 	values := r.URL.Query()
 	if r.Method == http.MethodGet {
 		return values, nil
@@ -508,8 +508,8 @@ func errorTypeForStatus(status int) string {
 // like the AWS RequestId: 22 chars of base32 (no padding). Base32
 // emits 1 char per 5 input bits, so 22 chars require ceil(22*5/8)=14
 // random bytes (110 bits, comfortably more entropy than a UUID-v4).
-// Gemini medium on PR #662 flagged the prior 16-byte source — that
-// produces a 26-char ID, not 22, and the comment was a lie.
+// A 16-byte source would produce a 26-char ID, not 22, so the byte
+// count is pinned at 14 to match the documented length.
 func newQueryRequestID() string {
 	var raw [14]byte
 	if _, err := rand.Read(raw[:]); err != nil {

adapter/sqs_query_protocol_test.go

@@ -148,8 +148,8 @@ func TestCollectIndexedKVPairs_Empty(t *testing.T) {
 }
 
 // TestNewQueryRequestID_Length pins the AWS shape: 22 base32 chars.
-// Gemini medium on PR #662 caught the prior 26-char output that
-// contradicted the function's own doc comment.
+// A regression where this function returned 26 chars contradicted
+// its own doc comment, so the length is asserted explicitly.
 func TestNewQueryRequestID_Length(t *testing.T) {
 	t.Parallel()
 	for i := 0; i < 64; i++ {