Fix ExtraOnSecondary test for buffered matchSecondary

bootjp · bootjp · commit 3785deb6affb · 2026-03-19T13:47:10.000+09:00
matchSecondary now buffers unmatched secondaries instead of reporting
immediately. Adjust the test to wait for the comparison window and
call sweepExpired to trigger divergence reporting.
diff --git a/proxy/shadow_pubsub_test.go b/proxy/shadow_pubsub_test.go
@@ -62,10 +62,15 @@ func TestShadowPubSub_MissingOnSecondary(t *testing.T) {
 }
 
 func TestShadowPubSub_ExtraOnSecondary(t *testing.T) {
-	sp := newTestShadowPubSub(100 * time.Millisecond)
+	sp := newTestShadowPubSub(10 * time.Millisecond)
 
 	sp.matchSecondary(&redis.Message{Channel: "ch1", Payload: "extra"})
 
+	// matchSecondary now buffers unmatched secondaries; wait for the
+	// comparison window to expire and sweep to trigger divergence reporting.
+	time.Sleep(20 * time.Millisecond)
+	sp.sweepExpired()
+
 	val := counterValue(sp.metrics.PubSubShadowDivergences.WithLabelValues("extra_data"))
 	assert.Equal(t, float64(1), val)
 }

Original file line number	Diff line number	Diff line change
`@@ -62,10 +62,15 @@ func TestShadowPubSub_MissingOnSecondary(t *testing.T) {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`func TestShadowPubSub_ExtraOnSecondary(t *testing.T) {`
`65`		`- sp := newTestShadowPubSub(100 * time.Millisecond)`
	`65`	`+ sp := newTestShadowPubSub(10 * time.Millisecond)`
`66`	`66`
`67`	`67`	`sp.matchSecondary(&redis.Message{Channel: "ch1", Payload: "extra"})`
`68`	`68`
	`69`	`+ // matchSecondary now buffers unmatched secondaries; wait for the`
	`70`	`+ // comparison window to expire and sweep to trigger divergence reporting.`
	`71`	`+ time.Sleep(20 * time.Millisecond)`
	`72`	`+ sp.sweepExpired()`
	`73`	`+`
`69`	`74`	`val := counterValue(sp.metrics.PubSubShadowDivergences.WithLabelValues("extra_data"))`
`70`	`75`	`assert.Equal(t, float64(1), val)`
`71`	`76`	`}`