Commit 563dd92
authored
feat(keyviz): per-cell conflict wire format + SPA per-cell hatching (Phase 2-C+ PR-3d) (#824)
## Summary
Promotes the row-level `conflict` bool to a per-cell `Conflicts []bool`
on the JSON `KeyVizRow`, so the SPA hatches only the columns that saw a
within-term fan-out merge disagreement instead of the whole row.
The per-cell conflict bit is **already computed** in the merge
accumulator (`cellMergeAcc.hasConflict`); PR-3c (#822) collapsed it to a
row-level OR. This closes that gap and aligns with parent design §9.1
("the cell is surfaced with `conflict=true`"). Design doc:
`docs/design/2026_05_25_proposed_keyviz_per_cell_conflict.md` (committed
first).
- `internal/admin/keyviz_handler.go` — `KeyVizRow` gains `Conflicts
[]bool` (`json:"conflicts,omitempty"`), parallel to `Values[]`.
- `internal/admin/keyviz_fanout.go` — `resolveRowMergeAcc` stamps
`Conflicts[j]` per write cell; row-level `Conflict` stays the OR for
older clients.
- `web/admin/src/pages/KeyViz.tsx` — `ConflictOverlay` hatches
individual cells when `conflicts[]` is present, falls back to whole-row
hatch when only the row-level `conflict` flag is set (legacy server).
- `web/admin/src/api/client.ts` — `KeyVizRow` type gains `conflicts?:
boolean[]`.
## Scope notes
- **JSON-only, no proto/gRPC change.** `proto.KeyVizRow` has never
carried a conflict field: conflict is a fan-out *merge* artifact, and
fan-out is JSON-over-HTTP peer aggregation; the single-node gRPC
`GetKeyVizMatrix` never merges. Adding `conflicts` to the proto would be
a field with no producer/consumer.
- **No algorithm change** — PR-3c's `(group, term)` dedupe +
fallback-max path is untouched; PR-3d only widens how the
already-computed per-cell bit reaches the client.
- **No new flag.** `omitempty` keeps `conflicts` off the wire on the
single-node / no-fan-out path.
## Compatibility
| Server | SPA | Behaviour |
|---|---|---|
| new | new | per-cell hatch |
| new | old | whole-row hatch (reads only `conflict`) |
| old | new | falls back to whole-row hatch |
| old | old | whole-row hatch (unchanged) |
## Self-review (five lenses)
1. **Data loss** — none; read-only admin path, no Raft/FSM/Pebble
interaction. `conflicts[]` is derived from existing merge state.
2. **Concurrency / distributed** — none new; merge runs synchronously
after the parallel peer fetch, no new shared mutable state.
Caller-audited `resolveRowMergeAcc` (one caller) and
`.Conflict`/`.Conflicts` (set only in `keyviz_fanout.go`; SPA is the
only consumer, via JSON).
3. **Performance** — one `make([]bool, width)` per merged write row
(bounded by the 1024-row budget); the conflict bit was already computed
per cell, no extra pass. `omitempty` avoids wire growth on quiet
matrices.
4. **Data consistency** — row-level `conflict` stays the exact OR of
`conflicts[]`; per-cell is strictly more precise. `(group, term)` dedupe
unchanged.
5. **Test coverage** — added
`TestMergeKeyVizMatricesPerCellConflictMarksOnlyAffectedColumn` (only
the disagreeing column flagged, row-level OR still true) and
`TestMergeKeyVizMatricesReadsLeaveConflictsNil`.
## Test evidence
- `go test -race -count=1 ./internal/admin/...` — pass
- `golangci-lint run internal/admin/...` — 0 issues
- `cd web/admin && npm run build` (`tsc -b && vite build`) — pass
(type-check clean)
- 6 files changed
Lines changed: 340 additions & 43 deletions
File tree
- docs/design
- internal/admin
- web/admin/src
- api
- pages
Lines changed: 158 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
| |||
475 | 475 | | |
476 | 476 | | |
477 | 477 | | |
478 | | - | |
479 | | - | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
480 | 481 | | |
481 | 482 | | |
482 | 483 | | |
| |||
716 | 717 | | |
717 | 718 | | |
718 | 719 | | |
719 | | - | |
720 | | - | |
721 | | - | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
722 | 723 | | |
723 | 724 | | |
724 | 725 | | |
| |||
738 | 739 | | |
739 | 740 | | |
740 | 741 | | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
741 | 750 | | |
742 | 751 | | |
743 | 752 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
| 206 | + | |
| 207 | + | |
206 | 208 | | |
207 | 209 | | |
208 | 210 | | |
| |||
234 | 236 | | |
235 | 237 | | |
236 | 238 | | |
| 239 | + | |
| 240 | + | |
237 | 241 | | |
238 | 242 | | |
239 | 243 | | |
| |||
307 | 311 | | |
308 | 312 | | |
309 | 313 | | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
310 | 398 | | |
311 | 399 | | |
312 | 400 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
81 | 83 | | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
| 84 | + | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
96 | 105 | | |
97 | 106 | | |
98 | 107 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
354 | 353 | | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
355 | 360 | | |
356 | 361 | | |
357 | 362 | | |
| |||
0 commit comments