Skip to content

Commit 5ee0175

Browse files
committed
style(admin/sqs): drop final test docstring PR attributions
Catches the three locations the prior round (7c63a7b) missed: adapter/sqs_admin_test.go (TestAdminQueueSummary_CreatedAtUsesMillisNotHLC, TestMetaAttributesForAdmin_IncludesQueueArnAndLastModified) and main_admin_test.go (TestTranslateAdminQueuesError_LeaderChurn). Same pattern: the why-rationale stays, only the "fifth-round Claude review on PR #670" / "seventh-round Claude review on PR #670" / "Codex P2 + Claude P1 on PR #670" attributions are dropped. Pre-existing PR #634 references at main_admin_test.go:373 / :397 were added by a prior merged PR and are out of scope here.
1 parent 7c63a7b commit 5ee0175

2 files changed

Lines changed: 14 additions & 16 deletions

File tree

adapter/sqs_admin_test.go

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ import (
88

99
const testQueueArn = "arn:aws:sqs:us-east-1:000000000000:orders"
1010

11-
// TestAdminQueueSummary_CreatedAtUsesMillisNotHLC pins the regression
12-
// from the fifth-round Claude review on PR #670: the admin
13-
// AdminDescribeQueue path was producing CreatedAt from
14-
// hlcToTime(meta.CreatedAtHLC), but sqsQueueMeta documents HLC as
15-
// "unsuitable for wall-clock display" and the SigV4 path
16-
// (sqs_catalog.go:942) reads CreatedAtMillis. Two failure modes the
17-
// test pins:
11+
// TestAdminQueueSummary_CreatedAtUsesMillisNotHLC pins the
12+
// invariant that the admin AdminDescribeQueue path derives
13+
// CreatedAt from sqsQueueMeta.CreatedAtMillis (the canonical
14+
// wall-clock field), not from hlcToTime(CreatedAtHLC) — the meta
15+
// struct documents HLC as "unsuitable for wall-clock display" and
16+
// the SigV4 path (sqs_catalog.go:942) reads CreatedAtMillis. Two
17+
// failure modes the test pins:
1818
//
1919
// 1. CreatedAtMillis == 0 must yield a zero time.Time so the JSON
2020
// encoder's omitempty drops the field and the SPA renders "—"
@@ -58,14 +58,13 @@ func TestAdminQueueSummary_CreatedAtUsesMillisNotHLC(t *testing.T) {
5858
})
5959
}
6060

61-
// TestMetaAttributesForAdmin_IncludesQueueArnAndLastModified pins the
62-
// gap from the seventh-round Claude review on PR #670: the prior
63-
// metaAttributesForAdmin docstring claimed parity with
64-
// queueMetaToAttributes("All") but neither QueueArn nor
65-
// LastModifiedTimestamp was emitted. QueueArn is the AWS-shaped
66-
// identifier the SPA shows for change-tracking; LastModifiedTimestamp
67-
// is updated on SetQueueAttributes and is the only handle operators
68-
// have on "when did somebody last touch this queue's config".
61+
// TestMetaAttributesForAdmin_IncludesQueueArnAndLastModified pins
62+
// the parity contract between metaAttributesForAdmin and
63+
// queueMetaToAttributes("All"): QueueArn (the AWS-shaped identifier
64+
// the SPA shows for change-tracking) and LastModifiedTimestamp
65+
// (updated on SetQueueAttributes — the only handle operators have
66+
// on "when did somebody last touch this queue's config") must both
67+
// be present.
6968
func TestMetaAttributesForAdmin_IncludesQueueArnAndLastModified(t *testing.T) {
7069
t.Parallel()
7170

main_admin_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,6 @@ func TestTranslateAdminTablesError_UnrelatedErrorPassesThrough(t *testing.T) {
433433
// still drop leadership inside deleteQueueWithRetry's Dispatch; the
434434
// resulting ErrLeaderNotFound / ErrNotLeader / wrapped suffixes must
435435
// classify as 503 leader_unavailable, not the generic 500 fallthrough.
436-
// Codex P2 + Claude P1 on PR #670 confirmed the original gap.
437436
func TestTranslateAdminQueuesError_LeaderChurn(t *testing.T) {
438437
cases := []struct {
439438
name string

0 commit comments

Comments
 (0)