Skip to content

Commit a2ab245

Browse files
committed
test(kv): merge import groups + drop tooling reference (PR #745 r2)
Round-2 review on commit 0be9fc7: - reviewdog/golangci (gci): test file still failed gci because the project convention puts ALL non-stdlib imports in a single group (no blank line between third-party and local). Round-2's "cockroachdb above bootjp with a blank line between" guess was wrong; merging into one alphabetical group (bootjp before cockroachdb) matches kv/coordinator.go and resolves the warning. - claude bot (nit): drop "Pulled in from gemini's PR #745 round-1 review" from the lower-bound rationale comment. Process metadata rots once the PR is merged; the design reason is what the source needs. No behavior change. Test still passes 6.05s.
1 parent 0be9fc7 commit a2ab245

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

kv/raft_engine_test.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@ import (
55
"testing"
66
"time"
77

8-
"github.com/cockroachdb/errors"
9-
108
"github.com/bootjp/elastickv/internal/raftengine"
9+
"github.com/cockroachdb/errors"
1110
)
1211

1312
// blockingLeaderView is a LeaderView whose VerifyLeader blocks until ctx is
@@ -54,11 +53,10 @@ func TestVerifyLeaderEngine_BoundsBlockingReadIndex(t *testing.T) {
5453
t.Fatalf("verifyLeaderEngine(blocking) err = %v; want DeadlineExceeded", err)
5554
}
5655
// Lower bound: confirm the engine actually held the call until the
57-
// deadline fired. Without this, a future regression that returned
58-
// DeadlineExceeded immediately (e.g. a misplaced ctx check before
59-
// the engine call) would silently pass. Pulled in from gemini's
60-
// PR #745 round-1 review — the upper bound alone proved bounded
61-
// completion but not "the timeout actually fired."
56+
// deadline fired, not that some other error path returned
57+
// immediately. Without this, a future regression that returned
58+
// DeadlineExceeded before doing any work (e.g. a misplaced ctx
59+
// check before the engine call) would silently pass.
6260
//
6361
// Tolerate a 200ms early-return slack so a slow CI scheduler that
6462
// trips ctx.Done() a hair before the wall clock catches up does

0 commit comments

Comments
 (0)